Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_draw: Fix blt tiled stride for gen2/3

Chris Wilson
2019-11-29T15:08:30Z

Quoting Ville Syrjala (2019-11-29 14:30:47)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Gen2/3 blitter doesn't want us to do the /4 adjustment
> to the tiled stride.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_draw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index 11bbfd0a1353..7e0edec198d2 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -551,7 +551,7 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
>
> blt_cmd_len = (gen >= 8) ? 0x5 : 0x4;
> blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
> - pitch = (tiling) ? buf->stride / 4 : buf->stride;
> + pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris