From: Petri Latvala <petri.latvala@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] .gitlab-ci/skopeo: Provide credentials on the cmd line
Date: Tue, 3 Dec 2019 12:46:00 +0200 [thread overview]
Message-ID: <20191203104600.GX25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20191203093433.170060-1-arkadiusz.hiler@intel.com>
On Tue, Dec 03, 2019 at 11:34:32AM +0200, Arkadiusz Hiler wrote:
> Newer version of skopeo seems to be broken when it comes to using the
> credentials file. Let's workaround this by providing them on the cmd
> line.
>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
For the series:
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> .gitlab-ci/pull-or-rebuild.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci/pull-or-rebuild.sh b/.gitlab-ci/pull-or-rebuild.sh
> index a9409db8..4f77431b 100755
> --- a/.gitlab-ci/pull-or-rebuild.sh
> +++ b/.gitlab-ci/pull-or-rebuild.sh
> @@ -50,14 +50,16 @@ if [ "$TYPE" = "base" ]; then
> podman push $DOCKERNAME
> fi
>
> - skopeo copy docker://$DOCKERNAME docker://$COMMITNAME
> + skopeo copy --dest-creds $CI_REGISTRY_USER:$CI_REGISTRY_PASSWORD \
> + docker://$DOCKERNAME docker://$COMMITNAME
> elif [ "$TYPE" = "igt" ]; then
> # container with IGT, we don't care about Dockerfile changes
> # we always rebuild
> set -e
> $PODMAN_BUILD -t $COMMITNAME -f $DOCKERFILE .
> podman push $COMMITNAME
> - skopeo copy docker://$COMMITNAME docker://$REFNAME
> + skopeo copy --dest-creds $CI_REGISTRY_USER:$CI_REGISTRY_PASSWORD \
> + docker://$COMMITNAME docker://$REFNAME
> else
> echo "unknown build type $TYPE"
> exit 1
> --
> 2.23.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-03 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 9:34 [igt-dev] [PATCH i-g-t 1/2] .gitlab-ci/skopeo: Provide credentials on the cmd line Arkadiusz Hiler
2019-12-03 9:34 ` [igt-dev] [PATCH i-g-t 2/2] .gitlab-ci: Use fixed version of image builder container Arkadiusz Hiler
2019-12-03 10:46 ` Petri Latvala [this message]
2019-12-03 11:31 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] .gitlab-ci/skopeo: Provide credentials on the cmd line Patchwork
2019-12-03 15:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203104600.GX25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox