From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] runner: Don't wait forever for processes to die
Date: Tue, 3 Dec 2019 12:58:31 +0200 [thread overview]
Message-ID: <20191203105831.GY25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <157537043129.7230.4065113539257661860@skylake-alporthouse-com>
On Tue, Dec 03, 2019 at 10:53:51AM +0000, Chris Wilson wrote:
> Quoting Petri Latvala (2019-12-03 10:44:57)
> > While the originally written timeout for process killing (2 seconds)
> > was way too short, waiting indefinitely is suboptimal as well. We're
> > seeing cases where the test is stuck for possibly hours in
> > uninterruptible sleep (IO). Wait a fairly longer selected time period
> > of 2 minutes, because even making progress for that long means the
> > machine is in bad enough state to require a good kicking and booting.
>
> I'd still vote for a fast exit if we know we have oopsed. No point
> waiting 2 minutes for children we know can't die.
Yes, good point. v2 coming up.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-03 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 10:44 [igt-dev] [PATCH i-g-t 1/2] runner: Actually ping watchdogs every interval Petri Latvala
2019-12-03 10:44 ` [igt-dev] [PATCH i-g-t 2/2] runner: Don't wait forever for processes to die Petri Latvala
2019-12-03 10:53 ` Chris Wilson
2019-12-03 10:58 ` Petri Latvala [this message]
2019-12-03 11:15 ` [igt-dev] [PATCH i-g-t v2 " Petri Latvala
2019-12-03 11:37 ` Chris Wilson
2019-12-03 11:39 ` [igt-dev] [PATCH i-g-t 1/2] runner: Actually ping watchdogs every interval Chris Wilson
2019-12-03 11:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] runner: Actually ping watchdogs every interval (rev2) Patchwork
2019-12-03 16:31 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203105831.GY25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox