From: Manasi Navare <manasi.d.navare@intel.com>
To: Karthik B S <karthik.b.s@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size
Date: Thu, 12 Dec 2019 19:08:19 -0800 [thread overview]
Message-ID: <20191213030818.GB27115@intel.com> (raw)
In-Reply-To: <20191209035118.6658-1-karthik.b.s@intel.com>
Thank you for the patch, pushed to igt
On Mon, Dec 09, 2019 at 09:21:18AM +0530, Karthik B S wrote:
> Loop through the connector's modes for both the tiled connectors and
> find a mode that matches the tile h size and tile v size.
> Request a modeset on this mode for both tiled connectors.
>
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/kms_dp_tiled_display.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_dp_tiled_display.c b/tests/kms_dp_tiled_display.c
> index 175ff12f..c86a055e 100644
> --- a/tests/kms_dp_tiled_display.c
> +++ b/tests/kms_dp_tiled_display.c
> @@ -207,9 +207,10 @@ static void test_cleanup(data_t *data)
>
> static void setup_mode(data_t *data)
> {
> - int count = 0, prev = 0;
> - bool pipe_in_use = false;
> + int count = 0, prev = 0, i = 0;
> + bool pipe_in_use = false, found = false;
> enum pipe pipe;
> + drmModeModeInfo *mode;
> igt_output_t *output;
> data_connector_t *conns = data->conns;
>
> @@ -226,6 +227,8 @@ static void setup_mode(data_t *data)
>
> for_each_pipe(data->display, pipe) {
> pipe_in_use = false;
> + found = false;
> +
> if (count > 0) {
> for (prev = count - 1; prev >= 0; prev--) {
> if (pipe == conns[prev].pipe) {
> @@ -247,6 +250,17 @@ static void setup_mode(data_t *data)
> }
> }
> igt_require(conns[count].pipe != PIPE_NONE);
> +
> + for (i = 0; i < conns[count].connector->count_modes; i++) {
> + mode = &conns[count].connector->modes[i];
> + if (mode->vdisplay == conns[count].tile.tile_v_size &&
> + mode->hdisplay == conns[count].tile.tile_h_size) {
> + found = true;
> + break;
> + }
> + }
> + igt_require(found);
> + igt_output_override_mode(output, mode);
> }
> igt_display_commit_atomic(data->display, DRM_MODE_ATOMIC_ALLOW_MODESET,
> NULL);
> --
> 2.22.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-13 3:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 3:51 [igt-dev] [PATCH i-g-t] tests/kms_dp_tiled_display: Request a mode on resolution that matches tile size Karthik B S
2019-12-09 4:23 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-12-13 1:54 ` Manasi Navare
2019-12-10 23:25 ` [igt-dev] [PATCH i-g-t] " Manasi Navare
2019-12-13 3:08 ` Manasi Navare [this message]
2019-12-13 8:26 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213030818.GB27115@intel.com \
--to=manasi.d.navare@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox