From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests: Open DRM_MASTER for display operations
Date: Wed, 18 Dec 2019 13:36:02 +0200 [thread overview]
Message-ID: <20191218113602.GH25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20191218112012.3539911-1-chris@chris-wilson.co.uk>
On Wed, Dec 18, 2019 at 11:20:12AM +0000, Chris Wilson wrote:
> To configure the display, one is required to be the DRM_MASTER.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/855
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/kms_content_protection.c | 2 +-
> tests/kms_panel_fitting.c | 2 +-
> tests/kms_plane_alpha_blend.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
> index 8b361fdef..3b9cedcb4 100644
> --- a/tests/kms_content_protection.c
> +++ b/tests/kms_content_protection.c
> @@ -654,7 +654,7 @@ static void test_content_protection_cleanup(void)
> igt_main
> {
> igt_fixture {
> - data.drm_fd = drm_open_driver(DRIVER_ANY);
> + data.drm_fd = drm_open_driver_master(DRIVER_ANY);
>
> igt_display_require(&data.display, data.drm_fd);
> }
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index ac24730f8..065fc2df8 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -252,7 +252,7 @@ igt_main
> data_t data = {};
>
> igt_fixture {
> - data.drm_fd = drm_open_driver(DRIVER_ANY);
> + data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> igt_display_require(&data.display, data.drm_fd);
> igt_display_require_output(&data.display);
> }
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index d7dc44ab9..085099f81 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -565,7 +565,7 @@ igt_main
> enum pipe pipe;
>
> igt_fixture {
> - data.gfx_fd = drm_open_driver(DRIVER_ANY);
> + data.gfx_fd = drm_open_driver_master(DRIVER_ANY);
> igt_require_pipe_crc(data.gfx_fd);
> igt_display_require(&data.display, data.gfx_fd);
> igt_require(data.display.is_atomic);
Don't they implicitly become masters if that's the first-and-only
open() on the dev? Did that change?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-18 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 11:20 [igt-dev] [PATCH i-g-t] tests: Open DRM_MASTER for display operations Chris Wilson
2019-12-18 11:31 ` Saarinen, Jani
2019-12-18 11:35 ` Chris Wilson
2019-12-18 11:36 ` Petri Latvala [this message]
2019-12-18 11:38 ` Chris Wilson
2019-12-18 11:49 ` Petri Latvala
2019-12-18 11:58 ` Chris Wilson
2019-12-18 12:05 ` Petri Latvala
2019-12-18 12:17 ` Kahola, Mika
2019-12-18 16:32 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218113602.GH25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox