From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Disable GEN12 media compression YUV tests
Date: Fri, 20 Dec 2019 19:12:02 +0200 [thread overview]
Message-ID: <20191220171202.GT1208@intel.com> (raw)
In-Reply-To: <20191220144852.14098-1-imre.deak@intel.com>
On Fri, Dec 20, 2019 at 04:48:52PM +0200, Imre Deak wrote:
> The Vebox backend needed for this is not ready yet for YUV formats,
> since that needs a separate AUX pagetable setup for the Y and UV planes
> and also setting up the matching format in the Vebox tiling convert
> command surface state.
>
> It makes sense to test the MC kernel patchset for regressions though, so
> let's disable the MC YUV tests until Vebox is able to handle those
> formats (and revert this patch when that happens and before the kernel
> patches enabling MC YUV formats get merged).
>
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> tests/kms_plane.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 9ef3a7f3..1474e265 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -595,6 +595,8 @@ static bool test_format_plane_yuv(data_t *data, enum pipe pipe,
> return true;
> if (!igt_plane_has_prop(plane, IGT_PLANE_COLOR_RANGE))
> return true;
Could use a comment perhaps so we don't forget why it's here.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + if (modifier == LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS)
> + return true;
>
> for (enum igt_color_encoding e = 0; e < IGT_NUM_COLOR_ENCODINGS; e++) {
> if (!igt_plane_try_prop_enum(plane,
> --
> 2.22.0
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-20 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 14:48 [igt-dev] [PATCH i-g-t] tests/kms_plane: Disable GEN12 media compression YUV tests Imre Deak
2019-12-20 17:12 ` Ville Syrjälä [this message]
2019-12-20 22:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-21 10:33 ` Imre Deak
2019-12-22 11:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220171202.GT1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox