From: Katarzyna Dec <katarzyna.dec@intel.com>
To: "Nayana, Venkata Ramana" <venkata.ramana.nayana@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Kempczynski@kdec5-desk.ger.corp.intel.com
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tests/i915/gem_fence: platforms not supporting fences
Date: Mon, 30 Dec 2019 09:00:33 +0100 [thread overview]
Message-ID: <20191230080033.GD2869@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20191220142515.13424-2-venkata.ramana.nayana@intel.com>
On Fri, Dec 20, 2019 at 07:55:15PM +0530, Nayana, Venkata Ramana wrote:
> For platforms not supporting fences(no aperture), skip tests
>
> Cc: Dec, Katarzyna <katarzyna.dec@intel.com>
> Cc: Kempczynski, Zbigniew <zbigniew.kempczynski@intel.com>
> Signed-off-by: Nayana, Venkata Ramana <venkata.ramana.nayana@intel.com>
> Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
> tests/i915/gem_fence_thrash.c | 2 +-
> tests/i915/gem_fenced_exec_thrash.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_fence_thrash.c b/tests/i915/gem_fence_thrash.c
> index c85c38bb..9beada98 100644
> --- a/tests/i915/gem_fence_thrash.c
> +++ b/tests/i915/gem_fence_thrash.c
> @@ -203,7 +203,7 @@ static int run_test(int threads_per_fence, void *f, int tiling,
> t.num_surfaces = surfaces_per_thread;
>
> num_fences = gem_available_fences(t.fd);
> - igt_assert_lt(0, num_fences);
> + igt_require(num_fences > 0);
>
> num_threads = threads_per_fence * num_fences;
>
> diff --git a/tests/i915/gem_fenced_exec_thrash.c b/tests/i915/gem_fenced_exec_thrash.c
> index e40fa438..db1b15aa 100644
> --- a/tests/i915/gem_fenced_exec_thrash.c
> +++ b/tests/i915/gem_fenced_exec_thrash.c
> @@ -165,7 +165,7 @@ igt_main
> igt_require_gem(fd);
>
> num_fences = gem_available_fences(fd);
> - igt_assert(num_fences > 4);
> + igt_require(num_fences > 4);
> igt_assert(num_fences <= MAX_FENCES);
>
> devid = intel_get_drm_devid(fd);
> --
> 2.24.0
>
This is not first version of this patch - next time (for new series) add which
version while generating patch (e.g. 'git format-patch -v2') and include change
log in commit msg:
v2: Removed X, Added Y
This patch was acked by Zbigniew. It looks good, so I think we can merge it.
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-30 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 14:25 [igt-dev] [PATCH i-g-t 0/1] tests/i915/gem_fence: platforms not supporting fences Nayana, Venkata Ramana
2019-12-20 14:25 ` [igt-dev] [PATCH i-g-t 1/1] " Nayana, Venkata Ramana
2019-12-30 8:00 ` Katarzyna Dec [this message]
2019-12-27 8:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-27 16:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230080033.GD2869@kdec5-desk.ger.corp.intel.com \
--to=katarzyna.dec@intel.com \
--cc=Kempczynski@kdec5-desk.ger.corp.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=venkata.ramana.nayana@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox