From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id B37186E214 for ; Thu, 16 Jan 2020 11:47:21 +0000 (UTC) Date: Thu, 16 Jan 2020 13:47:19 +0200 From: Petri Latvala Message-ID: <20200116114719.GR25209@platvala-desk.ger.corp.intel.com> References: <20200114091745.4555-1-petri.latvala@intel.com> <20200114091745.4555-4-petri.latvala@intel.com> <20200115130915.afkcbio4qu3muoxl@ahiler-desk1.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200115130915.afkcbio4qu3muoxl@ahiler-desk1.fi.intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Arkadiusz Hiler Cc: igt-dev@lists.freedesktop.org List-ID: On Wed, Jan 15, 2020 at 03:09:15PM +0200, Arkadiusz Hiler wrote: > On Tue, Jan 14, 2020 at 11:17:45AM +0200, Petri Latvala wrote: > > See also: commit 0e6457f1bfe2 ("lib: Don't dump log buffer when > > dynamic subtest failure is inherited") > > > > This is quite an explicit top-to-bottom test that we don't get an > > incorrect warn result for an innocent dynamic subtest. It is tested > > here in runner_test instead of testing in lib/tests that the extra > > lines are not printed, because not printing the extra lines is an > > implementation detail that might change later. The issue is after all > > about test results parsed by igt_runner. > > > > Signed-off-by: Petri Latvala > > Cc: Arkadiusz Hiler > > The whole series is > > Reviewed-by: Arkadiusz Hiler > > although I would squash patch 3 and 4 together Squashed and merged, with Arek's IRC ack on the end result. -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev