From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA7EE6E4CB for ; Fri, 17 Jan 2020 12:13:08 +0000 (UTC) Date: Fri, 17 Jan 2020 14:13:05 +0200 From: Petri Latvala Message-ID: <20200117121305.GT25209@platvala-desk.ger.corp.intel.com> References: <20200117091749.1606-1-mika.kahola@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117091749.1606-1-mika.kahola@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Mika Kahola Cc: igt-dev@lists.freedesktop.org List-ID: On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote: > The test is intended to test resolution changes from higher to > lower and back. We can test this with only one plane and we don't > need to run through all planes. This will save significant amount > of test execution time. > > Fix for > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899 I'm having a hard time understanding how this change fixes this issue. > > Signed-off-by: Mika Kahola > --- > tests/kms_plane_lowres.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c > index 4c3f5636..ee6fb1fb 100644 > --- a/tests/kms_plane_lowres.c > +++ b/tests/kms_plane_lowres.c > @@ -208,7 +208,8 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe, > igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres); > > igt_plane_set_fb(plane, NULL); > - tested++; > + if (tested++) > + break; At this point one must ask: Why have the count variable anymore? -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev