From: Petri Latvala <petri.latvala@intel.com>
To: "Kahola, Mika" <mika.kahola@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
Date: Fri, 17 Jan 2020 15:15:16 +0200 [thread overview]
Message-ID: <20200117131516.GU25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <357202513f72d3e36517dfffacdc49577ab786c4.camel@intel.com>
On Fri, Jan 17, 2020 at 02:44:40PM +0200, Kahola, Mika wrote:
> On Fri, 2020-01-17 at 14:13 +0200, Petri Latvala wrote:
> > On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> > > The test is intended to test resolution changes from higher to
> > > lower and back. We can test this with only one plane and we don't
> > > need to run through all planes. This will save significant amount
> > > of test execution time.
> > >
> > > Fix for
> > > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
> >
> > I'm having a hard time understanding how this change fixes this
> > issue.
> For some reason crc's don't match if we loop through multiple overlay
> planes. The reference image has primary, first overlay and cursors
> plane. Crc already fails if we compare the reference with the image
> having primary, second overlay and cursor plane. This I have been
> testing with TGL.
Commit message talks about saving test execution time but this
explanation is about working around failures.
What is actually broken and is this working around an issue or hiding
it? Is it always the same plane combination failing, every test round?
(Am I reading the test wrong though, as far as I can see there's just
two planes in use at a time, primary and one other...)
At the very least one plane of each type should be tested instead of
just the first non-primary.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-17 13:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 9:17 [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane Mika Kahola
2020-01-17 10:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-17 12:13 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-01-17 12:44 ` Kahola, Mika
2020-01-17 13:15 ` Petri Latvala [this message]
2020-01-17 14:35 ` Kahola, Mika
2020-01-20 12:02 ` Petri Latvala
2020-01-20 17:19 ` Ville Syrjälä
2020-01-22 8:55 ` Kahola, Mika
2020-01-20 11:39 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117131516.GU25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox