From: Imre Deak <imre.deak@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
Date: Tue, 21 Jan 2020 00:03:19 +0200 [thread overview]
Message-ID: <20200120220320.17092-2-imre.deak@intel.com> (raw)
In-Reply-To: <20200120220320.17092-1-imre.deak@intel.com>
On platforms without HW detiling use render copy or blitting to convert
between a tiled and a linear framebuffer.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
lib/igt_fb.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index c81b9de8..b5b1750e 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
return true;
}
+static bool hw_can_detile(const struct igt_fb *fb)
+{
+ if (fb->modifier == DRM_FORMAT_MOD_NONE)
+ return true;
+
+ if (!gem_has_legacy_hw_tiling(fb->fd))
+ return false;
+
+ return fb->modifier != I915_FORMAT_MOD_Yf_TILED;
+}
+
static bool use_enginecopy(const struct igt_fb *fb)
{
return is_ccs_modifier(fb->modifier) ||
- (fb->modifier == I915_FORMAT_MOD_Yf_TILED &&
- !blitter_ok(fb));
+ (!hw_can_detile(fb) && !blitter_ok(fb));
}
static bool use_blitter(const struct igt_fb *fb)
{
return (fb->modifier == I915_FORMAT_MOD_Y_TILED ||
- fb->modifier == I915_FORMAT_MOD_Yf_TILED) &&
+ !hw_can_detile(fb)) &&
blitter_ok(fb);
}
--
2.23.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-20 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
2020-01-20 22:03 ` Imre Deak [this message]
2020-01-21 16:19 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Juha-Pekka Heikkila
2020-01-21 16:35 ` Imre Deak
2020-01-21 17:59 ` Juha-Pekka Heikkila
2020-01-22 6:02 ` Dixit, Ashutosh
2020-01-22 9:34 ` Imre Deak
2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs " Imre Deak
2020-01-21 16:21 ` Juha-Pekka Heikkila
2020-01-21 4:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Patchwork
2020-01-21 19:26 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120220320.17092-2-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox