From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 718B0894C0 for ; Tue, 21 Jan 2020 13:51:19 +0000 (UTC) Date: Tue, 21 Jan 2020 15:51:15 +0200 From: Petri Latvala Message-ID: <20200121135115.GF25209@platvala-desk.ger.corp.intel.com> References: <1579586055-27583-1-git-send-email-kunal1.joshi@intel.com> <1579586055-27583-4-git-send-email-kunal1.joshi@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1579586055-27583-4-git-send-email-kunal1.joshi@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t v3 3/3] tests/kms_color_chamelium: add subtests to validate color List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Kunal Joshi Cc: ville.syrjala@intel.com, igt-dev@lists.freedesktop.org, daniel.vetter@intel.com List-ID: On Tue, Jan 21, 2020 at 11:24:15AM +0530, Kunal Joshi wrote: > To validate color subtests using chamelium, subtests modified > to do frame dump comparison instead of crc comparison. > Tests require chamelium and will validate color features > at pipe level. > > (v2) > Comparing framedump with framebuffer reference instead of > comparing two framedump. > (v3) > Moved common functions with kms_color to lib/igt_color > > Signed-off-by: Kunal Joshi > Signed-off-by: Swati Sharma > Suggested-by: Uma Shankar > --- > tests/Makefile.am | 1 + > tests/kms_color_chamelium.c | 759 ++++++++++++++++++++++++++++++++++++++++++++ Meson changes are missing. Looks pretty much what you'd expect from a kms_color ported to use chamelium. When you send the next revision, can you also include a patch with commit message "HAX: Run in BAT", modifying tests/intel-ci/fast-feedback.testlist to add all these new tests there. That way we get testing done on chameliums, which we currently only have on the BAT machines, not on shards. -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev