From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/2] i915/gem_engine_topology: Fix virtual engine check
Date: Wed, 22 Jan 2020 15:23:49 +0000 [thread overview]
Message-ID: <20200122152349.12154-2-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20200122152349.12154-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Engine class/instance have to be u16 for the virtual engine check to work.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/i915/gem_engine_topology.c | 2 +-
lib/igt_gt.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
index c3645eab8538..989a6e26d6ef 100644
--- a/lib/i915/gem_engine_topology.c
+++ b/lib/i915/gem_engine_topology.c
@@ -105,7 +105,7 @@ static const char *class_names[] = {
};
static void init_engine(struct intel_execution_engine2 *e2,
- int class, int instance, uint64_t flags)
+ uint16_t class, uint16_t instance, uint64_t flags)
{
int ret;
diff --git a/lib/igt_gt.h b/lib/igt_gt.h
index 6a8eceb68817..e880cd4ed11f 100644
--- a/lib/igt_gt.h
+++ b/lib/igt_gt.h
@@ -96,8 +96,8 @@ bool gem_class_can_store_dword(int fd, int class);
extern const struct intel_execution_engine2 {
char name[16];
- int class;
- int instance;
+ uint16_t class;
+ uint16_t instance;
uint64_t flags;
bool is_virtual;
} intel_execution_engines2[];
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-22 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:23 [igt-dev] [PATCH i-g-t 1/2] i915/gem_engine_topology: Generate engine names based on class Tvrtko Ursulin
2020-01-22 15:23 ` Tvrtko Ursulin [this message]
2020-01-22 18:04 ` [igt-dev] [PATCH i-g-t 2/2] i915/gem_engine_topology: Fix virtual engine check Chris Wilson
2020-01-22 17:56 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] i915/gem_engine_topology: Generate engine names based on class Patchwork
2020-01-22 18:03 ` [igt-dev] [PATCH i-g-t 1/2] " Chris Wilson
2020-01-23 13:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/2] " Patchwork
2020-01-23 19:55 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122152349.12154-2-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox