From: Kunal Joshi <kunal1.joshi@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v3 3/3] tests/kms_color_chamelium: add subtests to validate color
Date: Thu, 23 Jan 2020 12:30:06 +0530 [thread overview]
Message-ID: <20200123070005.GA19868@intel.com> (raw)
In-Reply-To: <20200121135115.GF25209@platvala-desk.ger.corp.intel.com>
On 2020-01-21 at 15:51:15 +0200, Petri Latvala wrote:
> On Tue, Jan 21, 2020 at 11:24:15AM +0530, Kunal Joshi wrote:
> > To validate color subtests using chamelium, subtests modified
> > to do frame dump comparison instead of crc comparison.
> > Tests require chamelium and will validate color features
> > at pipe level.
> >
> > (v2)
> > Comparing framedump with framebuffer reference instead of
> > comparing two framedump.
> > (v3)
> > Moved common functions with kms_color to lib/igt_color
> >
> > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> > Suggested-by: Uma Shankar <uma.shankar@intel.com>
> > ---
> > tests/Makefile.am | 1 +
> > tests/kms_color_chamelium.c | 759 ++++++++++++++++++++++++++++++++++++++++++++
>
>
> Meson changes are missing.
>
> Looks pretty much what you'd expect from a kms_color ported to use
> chamelium. When you send the next revision, can you also include a
> patch with commit message "HAX: Run in BAT", modifying
> tests/intel-ci/fast-feedback.testlist to add all these new tests
> there. That way we get testing done on chameliums, which we currently
> only have on the BAT machines, not on shards.
>
>
> --
> Petri Latvala
Thanks petri for the feedback and support.
I will float the next patch with recommended
changes.
Regards
Kunal
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-23 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 5:54 [igt-dev] [PATCH i-g-t v3 0/3] validate color tests using chamelium Kunal Joshi
2020-01-21 5:54 ` [igt-dev] [PATCH i-g-t v3 1/3] lib/igt_chamelium Added chamelium_frame_match_or_dump which returns bool that the captured frame matches Kunal Joshi
2020-01-21 13:29 ` Petri Latvala
2020-01-22 3:01 ` Kunal Joshi
2020-01-22 10:34 ` Petri Latvala
2020-01-21 5:54 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/kms_color_chamelium: add subtests to validate color Kunal Joshi
2020-01-21 13:51 ` Petri Latvala
2020-01-23 7:00 ` Kunal Joshi [this message]
[not found] ` <1579586055-27583-3-git-send-email-kunal1.joshi@intel.com>
2020-01-21 13:42 ` [igt-dev] [PATCH i-g-t v3 2/3] lib/igt_color Moved kms_color functions to lib/igt_color to git avoid code duplication Petri Latvala
2020-01-21 13:43 ` [igt-dev] ✓ Fi.CI.BAT: success for validate color tests using chamelium. (rev3) Patchwork
2020-01-22 12:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123070005.GA19868@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox