Re: [igt-dev] [PATCH i-g-t 3/7] lib/igt_kms: Add HDR_OUTPUT_METADATA connector property

Shankar, Uma
2020-01-14T14:32:46Z

>-----Original Message-----
>From: Sharma, Swati2 <swati2.sharma@intel.com>
>Sent: Tuesday, December 31, 2019 6:52 PM
>To: igt-dev@lists.freedesktop.org
>Cc: ville.syrjala@linux.intel.com; Shankar, Uma <uma.shankar@intel.com>; Hiler,
>Arkadiusz <arkadiusz.hiler@intel.com>; Nicholas Kazlauskas
><nicholas.kazlauskas@amd.com>; Leo Li <sunpeng.li@amd.com>; Harry Wentland
><harry.wentland@amd.com>; Sharma, Swati2 <swati2.sharma@intel.com>
>Subject: [igt-dev][PATCH i-g-t 3/7] lib/igt_kms: Add HDR_OUTPUT_METADATA
>connector property
>
>From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
>...and also reset it when resetting outputs since that can definitely affect CRC output
>on other tests when not reset.
>
>v2: rebase
>v3: rebase

Looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

>Cc: Leo Li <sunpeng.li@amd.com>
>Cc: Harry Wentland <harry.wentland@amd.com>
>Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>---
> lib/igt_kms.c | 5 +++++
> lib/igt_kms.h | 1 +
> 2 files changed, 6 insertions(+)
>
>diff --git a/lib/igt_kms.c b/lib/igt_kms.c index b0b064c9..de7472cd 100644
>--- a/lib/igt_kms.c
>+++ b/lib/igt_kms.c
>@@ -417,6 +417,7 @@ const char * const
>igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
> [IGT_CONNECTOR_HDCP_CONTENT_TYPE] = "HDCP Content Type",
> [IGT_CONNECTOR_LINK_STATUS] = "link-status",
> [IGT_CONNECTOR_MAX_BPC] = "max bpc",
>+ [IGT_CONNECTOR_HDR_OUTPUT_METADATA] =
>"HDR_OUTPUT_METADATA",
> };
>
> /*
>@@ -1794,6 +1795,10 @@ static void igt_output_reset(igt_output_t *output)
> if (igt_output_has_prop(output, IGT_CONNECTOR_CONTENT_PROTECTION))
> igt_output_set_prop_enum(output,
>IGT_CONNECTOR_CONTENT_PROTECTION,
> "Undesired");
>+
>+ if (igt_output_has_prop(output,
>IGT_CONNECTOR_HDR_OUTPUT_METADATA))
>+ igt_output_set_prop_value(output,
>+
>IGT_CONNECTOR_HDR_OUTPUT_METADATA, 0);
> }
>
> /**
>diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 36077d41..4766bfce 100644
>--- a/lib/igt_kms.h
>+++ b/lib/igt_kms.h
>@@ -126,6 +126,7 @@ enum igt_atomic_connector_properties {
> IGT_CONNECTOR_HDCP_CONTENT_TYPE,
> IGT_CONNECTOR_LINK_STATUS,
> IGT_CONNECTOR_MAX_BPC,
>+ IGT_CONNECTOR_HDR_OUTPUT_METADATA,
> IGT_NUM_CONNECTOR_PROPS
> };
>
>--
>2.24.1