From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [igt-dev] [PATCH] i915/tests/gem_exec_big: prefer PROT_WRITE
Date: Fri, 24 Jan 2020 16:41:31 +0000 [thread overview]
Message-ID: <20200124164131.39591-1-matthew.auld@intel.com> (raw)
Technically mmap__cpu and mmap__wc just ignore the prot value, so it
doesn't really matter, but the intention is to have write access to the
ptr, so make that clear. Also if the underlying mmap__wc were to at some
point use mmap_offset where the prot is not ignored then we won't have
any surprises.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_big.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index c06ee995..a5869330 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -217,9 +217,9 @@ static void exhaustive(int fd)
gem_write(fd, handle, 0, batch, sizeof(batch));
if (!FORCE_PREAD_PWRITE && gem_has_llc(fd))
- ptr = __gem_mmap__cpu(fd, handle, 0, batch_size, PROT_READ);
+ ptr = __gem_mmap__cpu(fd, handle, 0, batch_size, PROT_WRITE);
else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(fd))
- ptr = __gem_mmap__wc(fd, handle, 0, batch_size, PROT_READ);
+ ptr = __gem_mmap__wc(fd, handle, 0, batch_size, PROT_WRITE);
else
ptr = NULL;
@@ -281,9 +281,9 @@ static void single(int i915)
gem_write(i915, handle, 0, &bbe, sizeof(bbe));
if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
- ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
+ ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_WRITE);
else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
- ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
+ ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_WRITE);
else
ptr = NULL;
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-01-24 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 16:41 Matthew Auld [this message]
2020-01-24 16:46 ` [igt-dev] [PATCH] i915/tests/gem_exec_big: prefer PROT_WRITE Chris Wilson
2020-01-24 16:54 ` Matthew Auld
2020-01-24 17:10 ` Chris Wilson
2020-01-24 17:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-26 21:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124164131.39591-1-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox