From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88D456EAA1 for ; Mon, 27 Jan 2020 09:46:46 +0000 (UTC) Date: Mon, 27 Jan 2020 15:16:46 +0530 From: Ramalingam C Message-ID: <20200127094147.GA25694@intel.com> References: <20200127084610.29356-1-ramalingam.c@intel.com> <158011536751.25356.9436764177649025245@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158011536751.25356.9436764177649025245@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_create: Remove page nonaligned buffer tests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev List-ID: On 2020-01-27 at 08:56:07 +0000, Chris Wilson wrote: > Quoting Ramalingam C (2020-01-27 08:46:10) > > Considering that kernel returns the real memory size(page aligned) > > allocated, nonaligned buffer tests are not valid anymore. Hence removing > > them. > > > > > Signed-off-by: Ramalingam C > > cc: Chris Wilson > > --- > > tests/i915/gem_create.c | 46 ----------------------------------------- > > 1 file changed, 46 deletions(-) > > > > diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c > > index 8fc128dae6e2..d80479c757e8 100644 > > --- a/tests/i915/gem_create.c > > +++ b/tests/i915/gem_create.c > > @@ -119,46 +119,6 @@ static void invalid_size_test(int fd) > > igt_assert_eq(create_ioctl(fd, &create), -EINVAL); > > } > > > > -/* > > - * Creating an object with non-aligned size and trying to access it with an > > - * offset, which is greater than the requested size but smaller than the > > - * object's last page boundary. pwrite here must be successful. > > - */ > > -static void valid_nonaligned_size(int fd) > > -{ > > - struct drm_i915_gem_create create = { > > - .size = PAGE_SIZE / 2, > > - }; > > - char buf[PAGE_SIZE]; > > - > > - igt_assert_eq(create_ioctl(fd, &create), 0); > > - > > - gem_write(fd, create.handle, PAGE_SIZE / 2, buf, PAGE_SIZE / 2); > > - > > - gem_close(fd, create.handle); > > This is reasonable, just add a igt_assert(create.size >= PAGE_SIZE) as you mean igt_assert(create.size == PAGE_SIZE) right... ? I will update this test. -Ram > well. We pass in a small request, the kernel pads it to a minimum of > system page size so that it will work with the usual page aligned > interfaces. We verify that the extra size returned by the kernel is > usable. > > > -} > > - > > -/* > > - * Creating an object with non-aligned size and trying to access it with an > > - * offset, which is greater than the requested size and larger than the > > - * object's last page boundary. pwrite here must fail. > > - */ > > -static void invalid_nonaligned_size(int fd) > > -{ > > - struct drm_i915_gem_create create = { > > - .size = PAGE_SIZE / 2, > > - }; > > - char buf[PAGE_SIZE]; > > - > > - igt_assert_eq(create_ioctl(fd, &create), 0); > > - > > - /* This should fail. Hence cannot use gem_write. */ > > - igt_assert(__gem_write(fd, create.handle, > > - PAGE_SIZE / 2, buf, PAGE_SIZE)); > > This is falling under gem_write testing, since we aren't looking at > create.size and deliberating trying to write passed the end. > > So I wouldn't be upset losing this. > -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev