From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 627D36F9B1 for ; Thu, 30 Jan 2020 13:32:33 +0000 (UTC) Date: Thu, 30 Jan 2020 15:32:20 +0200 From: Imre Deak Message-ID: <20200130133220.GE20639@ideak-desk.fi.intel.com> References: <20200129181601.15918-1-imre.deak@intel.com> <20200129181601.15918-2-imre.deak@intel.com> <158037910689.16598.200295248016799513@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158037910689.16598.200295248016799513@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t 2/9] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org List-ID: On Thu, Jan 30, 2020 at 10:11:46AM +0000, Chris Wilson wrote: > Quoting Imre Deak (2020-01-29 18:15:54) > > On platforms w/o HW detiling don't fail creating the FB due to the > > expected error from the set_tiling IOCTL. > > > > Most of the tests use a cairo surface to draw, which don't depend on the > > HW detiling. Other tests (using lib/igt_draw.c or drawing to the FB > > directly, like kms_draw_crc, kms_frontbuffer) are failing atm and will > > need to be fixed separately. > > > > Cc: Juha-Pekka Heikkila > > Signed-off-by: Imre Deak > > --- > > lib/igt_fb.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/lib/igt_fb.c b/lib/igt_fb.c > > index c81b9de8..ec7e9991 100644 > > --- a/lib/igt_fb.c > > +++ b/lib/igt_fb.c > > @@ -944,9 +944,10 @@ static int create_bo_for_fb(struct igt_fb *fb) > > > > if (is_i915_device(fd)) { > > fb->gem_handle = gem_create(fd, fb->size); > > - gem_set_tiling(fd, fb->gem_handle, > > - igt_fb_mod_to_tiling(fb->modifier), > > - fb->strides[0]); > > + if (gem_has_legacy_hw_tiling(fd)) > > + gem_set_tiling(fd, fb->gem_handle, > > + igt_fb_mod_to_tiling(fb->modifier), > > + fb->strides[0]); > > /* If we can't use fences, we won't use ggtt detiling later */ > __gem_set_tiling() Ok. > -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev