From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 3/9] lib/intel_batchbuffer: Add blitter copy using XY_SRC_COPY_BLT
Date: Thu, 30 Jan 2020 16:23:24 +0200 [thread overview]
Message-ID: <20200130142324.GG20639@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <158037998804.16598.2815858479186185052@skylake-alporthouse-com>
On Thu, Jan 30, 2020 at 10:26:28AM +0000, Chris Wilson wrote:
> Quoting Chris Wilson (2020-01-30 10:17:40)
> > Quoting Imre Deak (2020-01-29 18:15:55)
> > > + if ((src_tiling | dst_tiling) >= I915_TILING_Y) {
> > > + igt_assert(gen >= 6);
> > > + batch[i++] = MI_FLUSH_DW | 2;
> >
> > MI_FLUSH_DW is only 3 dwords on gen6, so
> >
> > batch[i] = MI_FLUSH_DW | 1;
> > if (has_64b_reloc)
> > batch[i]++;
> > i++;
> >
> > or something prettier.
>
> Actually, you can get away with MI_FLUSH_DW | 2 as that should indicate
> a qword write instead for gen6/7.
Ok, making it qword for gen6/7 and dword for gen8+.
--Imre
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-30 14:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 18:15 [igt-dev] [PATCH i-g-t 1/9] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
2020-01-29 18:15 ` [igt-dev] [PATCH i-g-t 2/9] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling Imre Deak
2020-01-30 10:11 ` Chris Wilson
2020-01-30 13:32 ` Imre Deak
2020-01-29 18:15 ` [igt-dev] [PATCH i-g-t 3/9] lib/intel_batchbuffer: Add blitter copy using XY_SRC_COPY_BLT Imre Deak
2020-01-30 10:17 ` Chris Wilson
2020-01-30 10:26 ` Chris Wilson
2020-01-30 14:23 ` Imre Deak [this message]
2020-01-30 14:01 ` Imre Deak
2020-01-29 18:15 ` [igt-dev] [PATCH i-g-t 4/9] lib/igt_fb: Switch from XY_FAST_COPY_BLT to XY_SRC_COPY_BLT Imre Deak
2020-01-30 10:19 ` Chris Wilson
2020-01-30 13:27 ` Imre Deak
2020-01-29 18:15 ` [igt-dev] [PATCH i-g-t 5/9] lib/igt_fb: Add 64bpp support to the XY_SRC blit command Imre Deak
2020-01-29 18:15 ` [igt-dev] [PATCH i-g-t 6/9] lib/igt_fb: Fall back from gtt map to coherent map on platforms w/o aperture Imre Deak
2020-01-30 10:22 ` Chris Wilson
2020-01-30 13:17 ` Imre Deak
2020-01-29 18:15 ` [igt-dev] [PATCH i-g-t 7/9] lib/igt_fb: Use render copy/blit on platforms w/o HW detiling Imre Deak
2020-01-29 18:16 ` [igt-dev] [PATCH i-g-t 8/9] lib/igt_fb: Speed up format conversion for local memory Imre Deak
2020-01-30 10:24 ` Chris Wilson
2020-01-30 12:04 ` Imre Deak
2020-01-30 12:12 ` Chris Wilson
2020-01-30 13:10 ` Imre Deak
2020-01-30 18:20 ` Imre Deak
2020-01-29 18:16 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_plane: Fix format/mod for reference FB Imre Deak
2020-01-29 18:24 ` Imre Deak
2020-01-29 19:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/9] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Patchwork
2020-01-30 10:10 ` [igt-dev] [PATCH i-g-t 1/9] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130142324.GG20639@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox