From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: fix fbc checking rules
Date: Fri, 31 Jan 2020 15:22:02 +0200 [thread overview]
Message-ID: <20200131132202.GQ13686@intel.com> (raw)
In-Reply-To: <1580470869-698-1-git-send-email-juhapekka.heikkila@gmail.com>
On Fri, Jan 31, 2020 at 01:41:09PM +0200, Juha-Pekka Heikkila wrote:
> Fix FBC checking rules for scaledprimary subtests
>
> References: https://gitlab.freedesktop.org/drm/intel/issues/160
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_frontbuffer_tracking.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index c788b59..2c765c3 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2614,16 +2614,16 @@ static void scaledprimary_subtest(const struct test_mode *t)
> do_assertions(DONT_ASSERT_CRC);
>
> /*
> - * On gen <= 10 HW, FBC is not enabled on a plane with a Y offset
> + * On gen >= 9 HW, FBC is not enabled on a plane with a Y offset
> * that isn't divisible by 4, because it causes FIFO underruns.
> *
> * Check that FBC is disabled.
> */
> igt_fb_set_position(&new_fb, reg->plane,
> - reg->x + reg->w / 4, reg->y + src_y_upscale + 3);
> + reg->x + reg->w / 4, (reg->y + src_y_upscale) | 3);
> igt_fb_set_size(&new_fb, reg->plane, reg->w / 2, reg->h / 2);
> igt_display_commit2(&drm.display, COMMIT_UNIVERSAL);
> - do_assertions(DONT_ASSERT_CRC | (gen <= 10 ? ASSERT_FBC_DISABLED : 0));
> + do_assertions(DONT_ASSERT_CRC | (gen >= 9 ? ASSERT_FBC_DISABLED : 0));
>
> /* Back to the good and old blue fb. */
> igt_plane_set_fb(reg->plane, old_fb);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-31 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 11:41 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: fix fbc checking rules Juha-Pekka Heikkila
2020-01-31 13:12 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-31 13:22 ` Ville Syrjälä [this message]
2020-02-03 12:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131132202.GQ13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox