Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_basic: Skip subtest gtt if gtt mapping is unavailable

Chris Wilson
2020-01-31T08:20:06Z

Quoting Dixit, Ashutosh (2020-01-31 05:05:38)
> On Thu, 30 Jan 2020 16:15:16 -0800, Antonio Argenziano wrote:
> >
> > The subtest tries to do a gtt mapping but if there is no mappable
> > aperture that is not possible.
> >
> > Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> > ---
> > tests/i915/gem_exec_basic.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> > index 70dce34b..08336168 100644
> > --- a/tests/i915/gem_exec_basic.c
> > +++ b/tests/i915/gem_exec_basic.c
> > @@ -93,6 +93,7 @@ static void gtt(int fd, uint64_t flags)
> > struct drm_i915_gem_exec_object2 *exec;
> > uint32_t handle;
> >
> > + gem_require_mappable_ggtt(fd);
> > gem_require_ring(fd, flags);
> >
> > handle = gem_create(fd, 4096);
>
> Since the test is not really using any tiling features of the ggtt perhaps
> no need to skip? Instead how about this:

The test is very confused about its purpose in life and what it is
doing. Lets not confuse it any more. I'd remove it but we do we need
some testing of poisoned pointers -- and as inaccurate as this is, this
is the only example for execbuf.

Whatever it is, it is not a gem_exec_basic.
-Chris