Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_basic: Skip subtest gtt if gtt mapping is unavailable

Dixit, Ashutosh
2020-02-01T03:38:51Z

On Fri, 31 Jan 2020 09:04:16 -0800, Antonio Argenziano wrote:
>
> The subtest tries to do a gtt mapping but if there is no mappable
> aperture that is not possible.
>
> v2:
> - Skip the whole dynamic subtest. (Petri)

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Though Chris did have comments on this so he may want to review/ack this
too. Thanks!

> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/i915/gem_exec_basic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 70dce34b..b3c56369 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -141,6 +141,8 @@ igt_main
> }
>
> igt_subtest_with_dynamic("gtt") {
> + gem_require_mappable_ggtt(fd);
> +
> __for_each_physical_engine(fd, e) {
> igt_dynamic_f("%s", e->name)
> gtt(fd, e->flags);
> --
> 2.21.0