Re: [igt-dev] [PATCH i-g-t 8/9] tests/i915_suspend: skip fence related tests, if no mmap_gtt

Dixit, Ashutosh
2020-02-05T02:25:48Z

On Fri, 31 Jan 2020 09:31:08 -0800, Ramalingam C wrote:
>
> When mappable aperture is not available, skip the fencing related tests.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> tests/i915/i915_suspend.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c
> index 5a2ec76699d6..47e134b12086 100644
> --- a/tests/i915/i915_suspend.c
> +++ b/tests/i915/i915_suspend.c
> @@ -208,11 +208,15 @@ igt_main
> igt_fixture
> fd = drm_open_driver(DRIVER_INTEL);
>
> - igt_subtest("fence-restore-tiled2untiled")
> + igt_subtest("fence-restore-tiled2untiled") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, true, false);
> + }
>
> - igt_subtest("fence-restore-untiled")
> + igt_subtest("fence-restore-untiled") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, false, false);
> + }
>
> igt_subtest("debugfs-reader")
> test_debugfs_reader(fd, false);
> @@ -226,11 +230,15 @@ igt_main
> igt_subtest("forcewake")
> test_forcewake(fd, false);
>
> - igt_subtest("fence-restore-tiled2untiled-hibernate")
> + igt_subtest("fence-restore-tiled2untiled-hibernate") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, true, true);
> + }
>
> - igt_subtest("fence-restore-untiled-hibernate")
> + igt_subtest("fence-restore-untiled-hibernate") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, false, true);
> + }

Afaict test_fence_restore() is intimately related with gtt and tiling. So
skipping makes sense:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>