Re: [igt-dev] [PATCH i-g-t 9/9] tests/gem_tiling_max_stride: Skip if set tiling is not supported

Dixit, Ashutosh
2020-02-05T01:29:08Z

On Tue, 04 Feb 2020 16:43:01 -0800, Antonio Argenziano wrote:
> On 31/01/20 09:31, Ramalingam C wrote:
> > When mmapable aperture is not supported set tiling also not supported.
> > Hence skip the test.
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > ---
> > tests/i915/gem_tiling_max_stride.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/i915/gem_tiling_max_stride.c b/tests/i915/gem_tiling_max_stride.c
> > index 0e99d979f0ca..77f7223ba19b 100644
> > --- a/tests/i915/gem_tiling_max_stride.c
> > +++ b/tests/i915/gem_tiling_max_stride.c
> > @@ -71,6 +71,7 @@ igt_simple_main
> > fd = drm_open_driver(DRIVER_INTEL);
> > devid = intel_get_drm_devid(fd);
> > + gem_require_mappable_ggtt(fd);
>
> AFAICT it would not work without tiled access.
>
> Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>

Agreed:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>