Re: [igt-dev] [PATCH i-g-t 2/8] tests/kms_frontbuffer_tracking: Skip set tiling calls if not supported

Matt Roper
2020-02-10T22:32:02Z

On Fri, Feb 07, 2020 at 09:15:18PM +0200, Imre Deak wrote:
> From: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
>
> Skip the method that is setting tiling with invalid strides if the
> hardware does not support HW for tiling/de-tiling.
>
> v2:
> - Use gem_available_fences() to check for HW detiling.
>
> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
> tests/kms_frontbuffer_tracking.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 9c2c3a5d..724f5d16 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2833,7 +2833,8 @@ static void badstride_subtest(const struct test_mode *t)
> struct modeset_params *params = pick_params(t);
> int rc;
>
> - try_invalid_strides();
> + if (gem_available_fences(drm.fd))
> + try_invalid_strides();
>
> prepare_subtest(t, NULL);
>
> --
> 2.23.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795