Re: [igt-dev] [PATCH i-g-t 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer

Matt Roper
2020-02-10T22:47:13Z

On Fri, Feb 07, 2020 at 09:15:19PM +0200, Imre Deak wrote:
> From: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
>
> The GEM object used for the framebuffer does not need tiling to be set
> on it as the entire framebuffer is being filled with the same value -
> tiling will not impact the end value of the buffer.
>
> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
> tests/kms_available_modes_crc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
> index 12761343..ed43d1fb 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -211,17 +211,11 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
> data->buf = (unsigned char *)calloc(data->size*2, 1);
>
> data->gem_handle = gem_create(data->gfx_fd, gemsize);
> - ret = __gem_set_tiling(data->gfx_fd, data->gem_handle,
> - igt_fb_mod_to_tiling(tiling),
> - data->fb.strides[0]);
> -
> data->fb.gem_handle = data->gem_handle;
> data->fb.width = w;
> data->fb.height = h;
> fill_in_fb(data, output, plane, format);
>
> - igt_assert_eq(ret, 0);
> -
> ret = __kms_addfb(data->gfx_fd, data->gem_handle, w, h,
> format, tiling, data->fb.strides, data->fb.offsets,
> num_planes, LOCAL_DRM_MODE_FB_MODIFIERS,
> --
> 2.23.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795