From: Ramalingam C <ramalingam.c@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt
Date: Mon, 10 Feb 2020 11:17:55 +0530 [thread overview]
Message-ID: <20200210054755.GA29606@intel.com> (raw)
In-Reply-To: <158108667615.15496.13203855080851124379@skylake-alporthouse-com>
On 2020-02-07 at 14:44:36 +0000, Chris Wilson wrote:
> Quoting Ramalingam C (2020-02-07 13:45:27)
> > @@ -2016,16 +2016,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
> > /* GEM */
> > igt_subtest("gem-mmap-cpu")
> > gem_mmap_subtest(false);
> > - igt_subtest("gem-mmap-gtt")
> > + igt_subtest("gem-mmap-gtt") {
> > + gem_require_mappable_ggtt(drm_fd);
> > gem_mmap_subtest(true);
>
> Would not the lmem bar also be susceptible to power management
> artefacts?
Chris,
I think "gem-mmap-cpu" would do the same test with lmem, but that
can be done when we have the uAPI for allocating from lmem, through
another subtest say "gem-mmap-cpu-lmem"
But at present "gem-mmap-gtt" will fail at platforms where mmap_gtt is
not present. So to avoid that, could you please approve this change?
-Ram
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-10 5:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 13:45 [igt-dev] [PATCH i-g-t v2 1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt Ramalingam C
2020-02-07 13:45 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: " Ramalingam C
2020-02-07 14:44 ` Chris Wilson
2020-02-10 5:47 ` Ramalingam C [this message]
2020-02-10 6:36 ` Dixit, Ashutosh
2020-02-17 9:40 ` [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic subtests Ramalingam C
2020-02-17 9:44 ` Ramalingam C
2020-02-18 7:45 ` Chris Wilson
2020-02-18 9:07 ` C, Ramalingam
2020-02-18 10:59 ` Chris Wilson
2020-02-18 11:45 ` Chris Wilson
2020-03-10 3:27 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt Dixit, Ashutosh
2020-02-07 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: " Patchwork
2020-02-08 3:27 ` [igt-dev] [PATCH i-g-t v2 1/2] " Dixit, Ashutosh
2020-02-10 15:32 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/2] " Patchwork
2020-02-17 11:25 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt (rev2) Patchwork
2020-02-17 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210054755.GA29606@intel.com \
--to=ramalingam.c@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox