From: Matt Roper <matthew.d.roper@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture
Date: Mon, 10 Feb 2020 14:58:03 -0800 [thread overview]
Message-ID: <20200210225803.GR232048@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20200207191524.19362-5-imre.deak@intel.com>
On Fri, Feb 07, 2020 at 09:15:21PM +0200, Imre Deak wrote:
> Generate reference CRCs by drawing through a CPU mapping, which is also
> available on platforms w/o a GTT aperture.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> tests/kms_draw_crc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_draw_crc.c b/tests/kms_draw_crc.c
> index 6de9feae..f9d4b178 100644
> --- a/tests/kms_draw_crc.c
> +++ b/tests/kms_draw_crc.c
> @@ -187,7 +187,7 @@ static void draw_method_subtest(enum igt_draw_method method,
> * comparison. Cache the value so we don't recompute it for every single
> * subtest. */
It doesn't show in the context here, but the comment line just above
this says "Use IGT_DRAW_MMAP_GTT" --- that should be updated to match
the code change below.
Matt
> if (!base_crcs[format_index].set) {
> - get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index],
> + get_method_crc(IGT_DRAW_MMAP_CPU, formats[format_index],
> LOCAL_DRM_FORMAT_MOD_NONE,
> &base_crcs[format_index].crc);
> base_crcs[format_index].set = true;
> @@ -225,7 +225,7 @@ static void fill_fb_subtest(void)
> igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
> DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
>
> - igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT,
> + igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_CPU,
> 0, 0, fb.width, fb.height, 0xFF);
>
> rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0,
> --
> 2.23.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-10 22:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 19:15 [igt-dev] [PATCH i-g-t 1/8] lib/igt_draw: Refactor get_tiling calls Imre Deak
2020-02-07 19:15 ` [igt-dev] [PATCH i-g-t 2/8] tests/kms_frontbuffer_tracking: Skip set tiling calls if not supported Imre Deak
2020-02-08 22:36 ` Dixit, Ashutosh
2020-02-10 22:32 ` Matt Roper
2020-02-07 19:15 ` [igt-dev] [PATCH i-g-t 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer Imre Deak
2020-02-10 22:47 ` Matt Roper
2020-02-07 19:15 ` [igt-dev] [PATCH i-g-t 4/8] tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture Imre Deak
2020-02-10 22:51 ` Matt Roper
2020-02-07 19:15 ` [igt-dev] [PATCH i-g-t 5/8] tests/kms_draw_crc: Fix generating reference CRCs " Imre Deak
2020-02-10 22:58 ` Matt Roper [this message]
2020-02-11 0:38 ` Imre Deak
2020-02-07 19:15 ` [igt-dev] [PATCH i-g-t 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests " Imre Deak
2020-02-10 23:19 ` Matt Roper
2020-02-11 1:18 ` Imre Deak
2020-02-07 19:15 ` [igt-dev] [PATCH i-g-t 7/8] lib/igt_draw: Fix igt_draw_fill_fb() " Imre Deak
2020-02-10 23:22 ` Matt Roper
2020-02-07 19:15 ` [igt-dev] [PATCH i-g-t 8/8] lib/igt_fb: Make sure tiled YUV framebuffers are fully cleared Imre Deak
2020-02-10 23:34 ` Matt Roper
2020-02-11 1:26 ` Imre Deak
2020-02-07 19:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] lib/igt_draw: Refactor get_tiling calls Patchwork
2020-02-08 22:36 ` [igt-dev] [PATCH i-g-t 1/8] " Dixit, Ashutosh
2020-02-10 11:37 ` Imre Deak
2020-02-11 19:10 ` Dixit, Ashutosh
2020-02-11 19:18 ` Imre Deak
2020-02-12 4:17 ` Dixit, Ashutosh
2020-02-10 22:13 ` Matt Roper
2020-02-11 0:37 ` Imre Deak
2020-02-11 9:30 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/8] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210225803.GR232048@mdroper-desk1.amr.corp.intel.com \
--to=matthew.d.roper@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox