From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 11 Feb 2020 02:42:55 +0200 From: Andi Shyti Message-ID: <20200211004255.GA2535@jack.zhora.eu> References: <20200211003742.863630-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200211003742.863630-1-chris@chris-wilson.co.uk> Subject: Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: Hi Chris, On Tue, Feb 11, 2020 at 12:37:42AM +0000, Chris Wilson wrote: > The engine names are now stored inside the iterator and not as static > strings. If we wish to use them later, we need to make a copy. But we are not using them later. Your patch just copies and frees an array. Is there a follow-up? Andi > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > --- > tests/i915/gem_exec_nop.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c > index ed9568e5a..fc7f11827 100644 > --- a/tests/i915/gem_exec_nop.c > +++ b/tests/i915/gem_exec_nop.c > @@ -436,7 +436,7 @@ static void parallel(int fd, uint32_t handle, int timeout) > struct drm_i915_gem_execbuffer2 execbuf; > struct drm_i915_gem_exec_object2 obj; > unsigned engines[16]; > - const char *names[16]; > + char *names[16]; > unsigned nengine; > unsigned long count; > double time, sum; > @@ -445,7 +445,7 @@ static void parallel(int fd, uint32_t handle, int timeout) > nengine = 0; > __for_each_physical_engine(fd, e) { > engines[nengine] = e->flags; > - names[nengine++] = e->name; > + names[nengine++] = strdup(e->name); > > time = nop_on_ring(fd, handle, e, 1, &count) / count; > sum += time; > @@ -485,10 +485,11 @@ static void parallel(int fd, uint32_t handle, int timeout) > time = elapsed(&start, &now) / count; > igt_info("%s: %ld cycles, %.3fus\n", names[child], count, 1e6*time); > } > + while (nengine--) > + free(names[nengine]); > > igt_waitchildren(); > igt_assert_eq(intel_detect_and_clear_missed_interrupts(fd), 0); > - > } > > static void series(int fd, uint32_t handle, int timeout) > -- > 2.25.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx