From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51F266E29D for ; Tue, 11 Feb 2020 02:31:36 +0000 (UTC) From: Imre Deak Date: Tue, 11 Feb 2020 04:31:05 +0200 Message-Id: <20200211023108.25369-5-imre.deak@intel.com> In-Reply-To: <20200211023108.25369-1-imre.deak@intel.com> References: <20200211023108.25369-1-imre.deak@intel.com> MIME-Version: 1.0 Subject: [igt-dev] [PATCH v2 5/8] tests/kms_draw_crc: Fix generating reference CRCs on platforms w/o aperture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org List-ID: Generate reference CRCs by drawing through a CPU mapping, which is also available on platforms w/o a GTT aperture. v2: - Fix code comment in draw_method_subtest(). (Matt) Cc: Matt Roper Signed-off-by: Imre Deak --- tests/kms_draw_crc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_draw_crc.c b/tests/kms_draw_crc.c index 6de9feae..0e762ad1 100644 --- a/tests/kms_draw_crc.c +++ b/tests/kms_draw_crc.c @@ -183,11 +183,11 @@ static void draw_method_subtest(enum igt_draw_method method, igt_require(format_is_supported(formats[format_index], tiling)); - /* Use IGT_DRAW_MMAP_GTT on an untiled buffer as the parameter for + /* Use IGT_DRAW_MMAP_CPU on an untiled buffer as the parameter for * comparison. Cache the value so we don't recompute it for every single * subtest. */ if (!base_crcs[format_index].set) { - get_method_crc(IGT_DRAW_MMAP_GTT, formats[format_index], + get_method_crc(IGT_DRAW_MMAP_CPU, formats[format_index], LOCAL_DRM_FORMAT_MOD_NONE, &base_crcs[format_index].crc); base_crcs[format_index].set = true; @@ -225,7 +225,7 @@ static void fill_fb_subtest(void) igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb); - igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_GTT, + igt_draw_rect_fb(drm_fd, bufmgr, NULL, &fb, IGT_DRAW_MMAP_CPU, 0, 0, fb.width, fb.height, 0xFF); rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, -- 2.23.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev