From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 11 Feb 2020 11:53:07 +0200 From: Petri Latvala Message-ID: <20200211095307.GN25209@platvala-desk.ger.corp.intel.com> References: <2f2d74a2aa0bb1ab0050bdeb5a272ae9d7f61c69.1581381780.git.dale.b.stimson@intel.com> <20200211092200.GL25209@platvala-desk.ger.corp.intel.com> <877e0t1nfo.fsf@intel.com> <20200211093732.GM25209@platvala-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200211093732.GM25209@platvala-desk.ger.corp.intel.com> Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/3] i915/gem_mmio_base.c - get mmio_base from debugfs (if possible) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jani Nikula Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: On Tue, Feb 11, 2020 at 11:37:32AM +0200, Petri Latvala wrote: > On Tue, Feb 11, 2020 at 11:30:03AM +0200, Jani Nikula wrote: > > On Tue, 11 Feb 2020, Petri Latvala wrote: > > >> diff --git a/lib/i915/gem_mmio_base.c b/lib/i915/gem_mmio_base.c > > >> new file mode 100644 > > >> index 000000000..8718c092f > > >> --- /dev/null > > >> +++ b/lib/i915/gem_mmio_base.c > > >> @@ -0,0 +1,346 @@ > > >> +// Copyright (C) 2020 Intel Corporation > > >> +// > > >> +// SPDX-License-Identifier: MIT > > > > > > We don't use SPDX headers in IGT, please use the MIT license comment > > > block instead. > > > > Why not? Should we start? > > I'm all for it, but preferably not trickled in but as separate conversion! I have been informed from people with experience that converting to SPDX is more convoluted than I thought. Thus, take-backsies! SPDX for new files is ok. You can quote me on this. -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev