Re: [igt-dev] [PATCH i-g-t 7/9] lib/chamelium: Make it clear that function asserts

Petri Latvala
2020-02-17T14:00:51Z

On Mon, Feb 17, 2020 at 03:45:04PM +0200, Arkadiusz Hiler wrote:
> On Fri, Feb 14, 2020 at 02:19:58PM +0200, Petri Latvala wrote:
> > On Wed, Feb 12, 2020 at 03:23:13PM +0200, Arkadiusz Hiler wrote:
> > > chamelium_wait_reachable() is asserting internally if the chamelium not
> > > reachable. Let's make it return bool instead and create
> > > void chamelium_assert_reachable() that fails the run.
> > >
> > > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> >
> > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> >
> > Aside, Chamelium stuff is documented in a .txt but are there docs for
> > the lib/igt_chamelium functions anywhere?
>
> https://drm.pages.freedesktop.org/igt-gpu-tools/igt-gpu-tools-Chamelium.html ?

/me blind

I got confuz by the patch context not having documentation comments
visible. And speaking of, docs for chamelium_wait_reachable pls?

--
Petri Latvala