From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_dc: psr required only for dc*-psr tests
Date: Sun, 16 Feb 2020 23:30:06 +0530 [thread overview]
Message-ID: <20200216180006.14439-3-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20200216180006.14439-1-anshuman.gupta@intel.com>
DPMS igt tests were skipping for non-psr panels due to
psr_sink_support sink check added to igt_fixture() at
commit <6cbe6af372a01be63121056679d540436ffd0b64>.
DPMS dc state igt test don't require psr_sink_support, as it
validates DC states with all display being DPMS off.
Removing the psr sink check from igt_fixture and adding
it only for dc*- psr tests.
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/i915/i915_pm_dc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index 4bca8559..4c34ff9d 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -395,7 +395,6 @@ int main(int argc, char *argv[])
igt_require(igt_setup_runtime_pm(data.drm_fd));
igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
igt_display_require(&data.display, data.drm_fd);
- igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
/* Make sure our Kernel supports MSR and the module is loaded */
igt_require(igt_kmod_load("msr", NULL) == 0);
@@ -415,6 +414,7 @@ int main(int argc, char *argv[])
igt_subtest("dc5-psr") {
data.op_psr_mode = PSR_MODE_1;
psr_enable(data.debugfs_fd, data.op_psr_mode);
+ igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
test_dc_state_psr(&data, CHECK_DC5);
}
@@ -423,6 +423,7 @@ int main(int argc, char *argv[])
igt_subtest("dc6-psr") {
data.op_psr_mode = PSR_MODE_1;
psr_enable(data.debugfs_fd, data.op_psr_mode);
+ igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
"PC8+ residencies not supported\n");
test_dc_state_psr(&data, CHECK_DC6);
--
2.24.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-16 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 18:00 [igt-dev] [PATCH i-g-t 0/2] DC states IGT misc Anshuman Gupta
2020-02-16 18:00 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures Anshuman Gupta
2020-02-18 19:03 ` Souza, Jose
2020-02-19 3:38 ` Anshuman Gupta
2020-02-16 18:00 ` Anshuman Gupta [this message]
2020-02-18 18:55 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_dc: psr required only for dc*-psr tests Souza, Jose
2020-02-19 3:34 ` Anshuman Gupta
2020-02-19 18:01 ` Souza, Jose
2020-02-16 19:31 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states IGT misc (rev2) Patchwork
2020-02-19 0:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216180006.14439-3-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox