From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, Tomi Sarvela <tomi.p.sarvela@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests
Date: Mon, 17 Feb 2020 13:26:59 +0200 [thread overview]
Message-ID: <20200217112659.GJ25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <158193856695.19707.9026913900892754337@skylake-alporthouse-com>
On Mon, Feb 17, 2020 at 11:22:46AM +0000, Chris Wilson wrote:
> Quoting Petri Latvala (2020-02-17 11:17:28)
> > Oh, and in the same patch you can do this:
> >
> > Find the ugliest line you can find in tests/igt_command_line.sh and
> > change it to a prettier one.
>
> We can just delete it, right? Since with igt_subtest_with_dynamic() we
> always define the test group and so --list always reports something.
> Right?
The if (and the fi), yes.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-17 11:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 21:48 [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests Chris Wilson
2020-02-14 22:53 ` [igt-dev] ✗ GitLab.Pipeline: failure for " Patchwork
2020-02-14 23:05 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
2020-02-17 11:01 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-02-17 11:17 ` Petri Latvala
2020-02-17 11:22 ` Chris Wilson
2020-02-17 11:26 ` Petri Latvala [this message]
2020-02-17 11:32 ` Chris Wilson
2020-02-17 12:38 ` Petri Latvala
2020-02-17 11:36 ` Sarvela, Tomi P
2020-02-17 12:44 ` [igt-dev] [PATCH i-g-t v2] " Chris Wilson
2020-02-17 13:16 ` [igt-dev] ✗ GitLab.Pipeline: warning for lib: Update selftests to use dynamic subtests (rev3) Patchwork
2020-02-17 15:59 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217112659.GJ25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox