From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52A506E93D for ; Mon, 17 Feb 2020 12:38:35 +0000 (UTC) Date: Mon, 17 Feb 2020 14:38:32 +0200 From: Petri Latvala Message-ID: <20200217123832.GK25209@platvala-desk.ger.corp.intel.com> References: <20200214214829.4054673-1-chris@chris-wilson.co.uk> <20200217110130.GH25209@platvala-desk.ger.corp.intel.com> <20200217111728.GI25209@platvala-desk.ger.corp.intel.com> <158193856695.19707.9026913900892754337@skylake-alporthouse-com> <20200217112659.GJ25209@platvala-desk.ger.corp.intel.com> <158193913746.19707.7183869886572842911@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158193913746.19707.7183869886572842911@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org, Tomi Sarvela List-ID: On Mon, Feb 17, 2020 at 11:32:17AM +0000, Chris Wilson wrote: > Quoting Petri Latvala (2020-02-17 11:26:59) > > On Mon, Feb 17, 2020 at 11:22:46AM +0000, Chris Wilson wrote: > > > Quoting Petri Latvala (2020-02-17 11:17:28) > > > > Oh, and in the same patch you can do this: > > > > > > > > Find the ugliest line you can find in tests/igt_command_line.sh and > > > > change it to a prettier one. > > > > > > We can just delete it, right? Since with igt_subtest_with_dynamic() we > > > always define the test group and so --list always reports something. > > > Right? > > > > The if (and the fi), yes. > > --- a/tests/igt_command_line.sh > +++ b/tests/igt_command_line.sh > @@ -92,10 +92,8 @@ check_test () > # Subtest enumeration of kernel selftest launchers depends > # on the running kernel. If selftests are not enabled, > # they will output nothing and exit with 0. > - if [ "$testname" != "i915_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" -a "$testname" != "dmabuf" ]; then > - echo " test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!" > - fail $test > - fi > + echo " test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!" > + fail $test > fi With all the rejoicing of being able to remove an ugly workaround, I forgot that the above comment needs to go as well. Five lines removed still counts as a one-liner, right? -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev