From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 725D96E06E for ; Wed, 19 Feb 2020 03:47:14 +0000 (UTC) Date: Wed, 19 Feb 2020 09:08:47 +0530 From: Anshuman Gupta Message-ID: <20200219033847.GD7545@intel.com> References: <20200216180006.14439-1-anshuman.gupta@intel.com> <20200216180006.14439-2-anshuman.gupta@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Souza, Jose" Cc: "igt-dev@lists.freedesktop.org" List-ID: On 2020-02-19 at 00:33:09 +0530, Souza, Jose wrote: > On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote: > > Dump i915_power_domain_info debugfs attribute on DC state > > test failures, it will help to identify culprit, which > > causes non zero refcount for "DC off" power well. > > > > Cc: Animesh Manna > > Signed-off-by: Anshuman Gupta > > --- > > tests/i915/i915_pm_dc.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c > > index afcc10bc..4bca8559 100644 > > --- a/tests/i915/i915_pm_dc.c > > +++ b/tests/i915/i915_pm_dc.c > > @@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd, > > int dc_flag, int prev_dc_count) > > static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t > > prev_dc_count) > > { > > char tmp[64]; > > + char file[64] = "i915_power_domain_info"; > > > > snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ? > > "DC3CO" : > > (dc_flag & CHECK_DC5 ? "DC5" : "DC6")); > > igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag, > > prev_dc_count), > > - "%s state is not achieved\n", tmp); > > + "%s state is not achieved\n%s:\n%s\n", > > + tmp, file, igt_sysfs_get(debugfs_fd, file)); > > } > > You are leaking the return of igt_sysfs_get() also why add the variable > file? Thanks for review, i will fix the leak and will take a macro instead of file. Thanks, Anshuman Gupta. > > > > > static void setup_videoplayback(data_t *data) _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev