Re: [igt-dev] [PATCH i-g-t 1/1] tools/generate_cb_buffer: Add script to assemble CB kernel

Petri Latvala
2020-02-20T10:11:04Z

On Thu, Feb 20, 2020 at 03:06:09AM +0200, Abodunrin, Akeem G wrote:
> > > +export ASSEMBLY_SOURCE=./tools/assembly_source
> > > +
> > > +function get_help {
> > > + echo "Usage: asm_eu_kernel.sh [options]"
> > > + echo "Remember to run this as root"
> >
> > I can't spot why this would need root.
> Since we are generating new file, and writing to it - the script definitely needs root access... otherwise commands like this " prefix_header $i915_filename "Media CB Kernel for gen7.5 devices"" fails

That's no reason to need root. That's just a reason to need write
access to the directory where you're creating the files.

As you require the script to be run in IGT source root and writing to
$cwd, you need write access to IGT source root. Which shouldn't be
root-owned.

> >
> >
> > > + echo " "
> > > + echo "Please make sure your MESA tool is compiled, and run this script
> > from igt home directory"
> >
> > Mesa written as "Mesa" and IGT written as "IGT". And it's "source root
> > directory", not "home directory".
> >
> > Does the assembler require specific build options for Mesa? Note them here.
>
> Yes, it does - but the options are hardcoded in this script - so, mentioning them in the help function is irrelevant...

I'm asking about the Mesa _build_ options. This script doesn't build
Mesa, it just uses it.

From a quick check that would be -Dtools=intel that is required.

--
Petri Latvala