From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3F366EB84 for ; Wed, 19 Feb 2020 13:28:00 +0000 (UTC) Date: Wed, 19 Feb 2020 15:27:58 +0200 From: Petri Latvala Message-ID: <20200219132758.GT25209@platvala-desk.ger.corp.intel.com> References: <20200219121940.18247-1-petri.latvala@intel.com> <158211860207.8112.2166645472651306406@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158211860207.8112.2166645472651306406@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t] runner/resultgen: Provide output when test output is completely empty List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org List-ID: On Wed, Feb 19, 2020 at 01:23:22PM +0000, Chris Wilson wrote: > Quoting Petri Latvala (2020-02-19 12:19:40) > > If a machine is hard-hanging or otherwise rebooted at the correct > > time, intermediary output files get created but nothing ever gets > > written to them. That yields results that are completely empty and > > hard to categorize or even sometimes detect automatically. Handle this > > corner case explicitly with a custom text explaining what might have > > happened to prod result analysis towards fixing the real issue instead > > of wondering if test result processing is faulty. > > > > The race for getting empty files is easier to hit than it seems. The > > files get created by the runner before calling exec(), and there's > > plenty of time to hit a really hard crash. > > Speaking of which, it would not be terrible if igt_runner periodically > called sync() everytime it decided there were new logs to preserve. > We should also probably remove/reduce the writeback delay. Does calling sync() sync more than fsyncdata()? -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev