public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry
Date: Thu, 20 Feb 2020 17:41:55 +0000	[thread overview]
Message-ID: <20200220174155.2162242-1-chris@chris-wilson.co.uk> (raw)

Since we check before and then after each debugfs entry, we do not need
to check before each time as well. We will error out as soon as it does
fail, at all other times we know the system to be idle.

No impact on runtime for glk (which apparently is one of the better
behaving systems).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
---
 tests/i915/i915_pm_rpm.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 0c2821122..bf412b5cc 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -932,9 +932,6 @@ static int read_entry(const char *filepath,
 	int fd;
 	int rc;
 
-	igt_assert_f(wait_for_suspended(), "Before opening: %s (%s)\n",
-		     filepath + pathinfo->base, filepath);
-
 	fd = open(filepath, O_RDONLY | O_NONBLOCK);
 	if (fd < 0) {
 		igt_debug("Failed to open '%s': %m\n", filepath);
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-02-20 17:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 17:41 Chris Wilson [this message]
2020-02-20 19:56 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry Patchwork
2020-02-21  7:33 ` [igt-dev] [PATCH i-g-t] " Martin Peres
2020-02-21  8:21   ` Chris Wilson
2020-02-21  8:28     ` Martin Peres
2020-02-21 13:55       ` Chris Wilson
2020-02-21 13:56 ` [Intel-gfx] " Chris Wilson
2020-02-24  9:16   ` [igt-dev] " Martin Peres
2020-02-24  9:59     ` Chris Wilson
2020-02-21 15:38 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry (rev2) Patchwork
2020-02-23  4:27 ` [igt-dev] ✓ Fi.CI.IGT: success for i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry Patchwork
2020-02-24 10:52 ` [igt-dev] ✓ Fi.CI.IGT: success for i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200220174155.2162242-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox