From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C0B46EF24 for ; Fri, 21 Feb 2020 09:58:22 +0000 (UTC) Date: Fri, 21 Feb 2020 11:58:16 +0200 From: Petri Latvala Message-ID: <20200221095816.GZ25209@platvala-desk.ger.corp.intel.com> References: <20200218163540.12637-1-akeem.g.abodunrin@intel.com> <20200218163540.12637-2-akeem.g.abodunrin@intel.com> <20200219110610.GS25209@platvala-desk.ger.corp.intel.com> <20200220101058.GX25209@platvala-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tools/generate_cb_buffer: Add script to assemble CB kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Abodunrin, Akeem G" Cc: "Luck, Tony" , "Aran, Omer" , "Nikula, Jani" , "Wilson, Chris P" , "Stewart, David C" , "igt-dev@lists.freedesktop.org" , "Pathi, Pragyansri" , "Bloomfield, Jon" , "Vetter, Daniel" , "Kuoppala, Mika" List-ID: On Thu, Feb 20, 2020 at 10:22:48PM +0200, Abodunrin, Akeem G wrote: > > On Thu, Feb 20, 2020 at 03:06:09AM +0200, Abodunrin, Akeem G wrote: > > > > > +export ASSEMBLY_SOURCE=./tools/assembly_source > > > > > + > > > > > +function get_help { > > > > > + echo "Usage: asm_eu_kernel.sh [options]" > > > > > + echo "Remember to run this as root" > > > > > > > > I can't spot why this would need root. > > > Since we are generating new file, and writing to it - the script > > > definitely needs root access... otherwise commands like this " > > > prefix_header $i915_filename "Media CB Kernel for gen7.5 devices"" > > > fails > > > > That's no reason to need root. That's just a reason to need write access to the > > directory where you're creating the files. > > > > As you require the script to be run in IGT source root and writing to $cwd, you > > need write access to IGT source root. Which shouldn't be root-owned. > > I got you - but I don't think this is a big deal - I will remove it in the next spin... but not sure it adds any value at this point. > > > > > > > > > > > > > > > > > + echo " " > > > > > + echo "Please make sure your MESA tool is compiled, and > > > > > + run this script > > > > from igt home directory" > > > > > > > > Mesa written as "Mesa" and IGT written as "IGT". And it's "source > > > > root directory", not "home directory". > > > > > > > > Does the assembler require specific build options for Mesa? Note them here. > > > > > > Yes, it does - but the options are hardcoded in this script - so, mentioning them > > in the help function is irrelevant... > > > > I'm asking about the Mesa _build_ options. This script doesn't build Mesa, it just > > uses it. > > > > From a quick check that would be -Dtools=intel that is required. > I don't think Mesa requires Kernel build options to work, AFAIK - it is a standalone tool that could be installed in different ways as mentioned here "https://www.mesa3d.org/install.html" - So, no need for that information. Kernel build options? When I said Mesa, I meant Mesa. The line that states "make sure your Mesa tool is compiled" needs to add " with -Dtools=intel " because the assembler won't be there otherwise! -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev