public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: Martin Peres <martin.peres@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] intel-ci: add a pre-merge blacklist to reduce the testing queue
Date: Fri, 21 Feb 2020 13:27:30 +0200	[thread overview]
Message-ID: <20200221112730.GE25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200221102033.GC25209@platvala-desk.ger.corp.intel.com>

On Fri, Feb 21, 2020 at 12:20:33PM +0200, Petri Latvala wrote:
> On Thu, Feb 20, 2020 at 05:32:09PM +0200, Martin Peres wrote:
> > When arriving at the office on Monday morning, the reported queue
> > size was ~100 hours. This defeats the point of pre-merge testing and
> > vastly exceeds our target of ~6 hours.
> > 
> > We have a lot of work needed to reduce testing time, but this patches
> > reduces the reported run time by 15-30% depending on the platforms:
> > 
> >  - shard-skl: 23.9 -> 18.2 minutes (18.5%)
> >  - shard-kbl: 21.2 -> 16.2 minutes (20%)
> >  - shard-apl: 25.9 -> 18.5 minutes (24.3%)
> >  - shard-glk: 24.7 -> 17.6 minutes (24.8%)
> >  - shard-icl: 25.1 -> 16.7 minutes (28.7%)
> >  - shard-tgl: 28.2 -> 19.6 minutes (26.4%)
> > 
> > The reason why the reported runtime is so low compared to the
> > actual time is due to:
> > 
> >  - Unaccounted time spent outside of the IGT subtests (exec(), fixtures)
> >  - Unaccounted time spent in suspend (monotonic clock, 20s / suspend)
> >  - Boot time / extra reboots between shards to workaround kernel failures
> >  - Intel GFX CI shard scheduling overhead
> >  - More?
> > 
> > Tomi and Petri are working on reducing these overheads by detecting the
> > bad conditions and rebooting the machine only at this point rather than
> > between every single shard, and increasing the size of the shard test
> > lists to reduce the per-shard CI overhead.
> > 
> > Because of this, the actual savings are way smaller in percentage
> > but still compound over the tens of executions we do per week:
> > 
> >  - shard-skl: ~58 -> ~52 minutes
> >  - shard-kbl: ~50 -> ~45 minutes
> >  - shard-apl: ~53 -> ~46 minutes
> >  - shard-glk: ~38 -> ~31 minutes
> >  - shard-icl: ~47 -> ~39 minutes
> >  - shard-tgl: ~60 -> ~51 minutes
> > 
> > More work needed, but we'll get there :)
> > 
> > Signed-off-by: Martin Peres <martin.peres@linux.intel.com>
> > ---
> >  tests/intel-ci/README                  |   7 +
> >  tests/intel-ci/blacklist-pre-merge.txt | 221 +++++++++++++++++++++++++
> 
> 
> With a drive-by addition of a forgotten blacklist.txt, squash this in:
> 
> diff --git a/tests/intel-ci/meson.build b/tests/intel-ci/meson.build
> index b3abb848..62811e92 100644
> --- a/tests/intel-ci/meson.build
> +++ b/tests/intel-ci/meson.build
> @@ -3,6 +3,8 @@ intelci_files = [
>    'fast-feedback.testlist',
>    'meta.testlist',
>    'README',
> +  'blacklist.txt',
> +  'blacklist-pre-merge.txt',
>  ]
>  
>  install_data(sources : intelci_files, install_dir : datadir)


With Martin's IRL ack to squashing this, the patch is now merged.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-02-21 11:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 15:32 [igt-dev] [PATCH i-g-t] intel-ci: add a pre-merge blacklist to reduce the testing queue Martin Peres
2020-02-20 15:39 ` Chris Wilson
2020-02-20 15:43 ` Chris Wilson
2020-02-20 17:41   ` Chris Wilson
2020-02-20 15:44 ` Chris Wilson
2020-02-20 16:19   ` Peres, Martin
2020-02-20 15:46 ` Chris Wilson
2020-02-21  8:10   ` Martin Peres
2020-02-20 15:50 ` Chris Wilson
2020-02-21  8:11   ` Martin Peres
2020-02-20 15:52 ` Chris Wilson
2020-02-21  8:11   ` Martin Peres
2020-02-20 15:58 ` Chris Wilson
2020-02-20 16:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-21  9:00 ` [igt-dev] [PATCH i-g-t v2] " Martin Peres
2020-02-21 10:11   ` Petri Latvala
2020-02-21 10:43   ` Chris Wilson
2020-02-21  9:42 ` [igt-dev] ✓ Fi.CI.BAT: success for intel-ci: add a pre-merge blacklist to reduce the testing queue (rev2) Patchwork
2020-02-21 10:20 ` [igt-dev] [PATCH i-g-t] intel-ci: add a pre-merge blacklist to reduce the testing queue Petri Latvala
2020-02-21 11:27   ` Petri Latvala [this message]
2020-02-22 21:32 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221112730.GE25209@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=martin.peres@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox