Re: [igt-dev] [PATCH i-g-t] tests/kms_psr2_su: Print the SU blocks mismatches

[Anshuman Gupta <anshuman.gupta@intel.com>]

On 2020-01-23 at 11:00:29 -0800, José Roberto de Souza wrote:
> This will help us debug failures in this test.
> 
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  tests/kms_psr2_su.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_psr2_su.c b/tests/kms_psr2_su.c
> index f2244b29..9f40c735 100644
> --- a/tests/kms_psr2_su.c
> +++ b/tests/kms_psr2_su.c
> @@ -183,9 +183,13 @@ static bool update_screen_and_test(data_t *data)
>  		igt_assert_f(data->op, "Operation not handled\n");
>  	}
>  
> -	if (psr2_wait_su(data->debugfs_fd, &su_blocks))
> +	if (psr2_wait_su(data->debugfs_fd, &su_blocks)) {
>  		ret = su_blocks == EXPECTED_NUM_SU_BLOCKS;
>  
> +		if (!ret)
> +			igt_debug("Not matching SU blocks read: %u\n", su_blocks);
AFAIU this will print the SU block for 0th frame, and looks like
this test also interested only in 0th frame, i am just curious here to know the 
use case of SU block for last 8 frames.
> +	}
> +
>  	return ret;
>  }
>  
> @@ -206,7 +210,6 @@ static void run(data_t *data)
>  			result = update_screen_and_test(data);
>  	}
>  
> -	igt_debug("Screen changes: %u\n", data->screen_changes);
IMHO this seems unrealted to this patch considering its commit log, could u please
add some description about removal of this log.
Thanks,
Anshuman Gupta.
>  	igt_assert_f(result,
>  		     "No matching selective update blocks read from debugfs\n");
>  }
> -- 
> 2.25.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev