From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Move PSR checks back to individual subtests
Date: Fri, 28 Feb 2020 20:22:28 +0200 [thread overview]
Message-ID: <20200228182229.1860-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The dpms tests don't need PSR. So move the PSR check back into
the subtests that need it.
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Fixes: 6cbe6af372a0 ("tests/i915_pm_dc: Use psr_sink_support instead of reimplement it again")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/i915/i915_pm_dc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index afcc10bc7e20..6975f165be7f 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -393,7 +393,6 @@ int main(int argc, char *argv[])
igt_require(igt_setup_runtime_pm(data.drm_fd));
igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
igt_display_require(&data.display, data.drm_fd);
- igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
/* Make sure our Kernel supports MSR and the module is loaded */
igt_require(igt_kmod_load("msr", NULL) == 0);
@@ -405,6 +404,7 @@ int main(int argc, char *argv[])
igt_describe("In this test we make sure that system enters DC3CO "
"when PSR2 is active and system is in SLEEP state");
igt_subtest("dc3co-vpb-simulation") {
+ igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
test_dc3co_vpb_simulation(&data);
}
@@ -412,6 +412,7 @@ int main(int argc, char *argv[])
"while PSR is active");
igt_subtest("dc5-psr") {
data.op_psr_mode = PSR_MODE_1;
+ igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
psr_enable(data.debugfs_fd, data.op_psr_mode);
test_dc_state_psr(&data, CHECK_DC5);
}
@@ -420,6 +421,7 @@ int main(int argc, char *argv[])
"while PSR is active");
igt_subtest("dc6-psr") {
data.op_psr_mode = PSR_MODE_1;
+ igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
psr_enable(data.debugfs_fd, data.op_psr_mode);
igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
"PC8+ residencies not supported\n");
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-02-28 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 18:22 Ville Syrjala [this message]
2020-02-28 18:22 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_dc: Fix the description of dc6-dpms Ville Syrjala
2020-02-28 18:32 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Move PSR checks back to individual subtests Souza, Jose
2020-02-28 18:47 ` Ville Syrjälä
2020-02-28 20:34 ` Souza, Jose
2020-02-28 19:16 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2020-03-01 15:42 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228182229.1860-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox