Re: [igt-dev] [PATCH i-g-t] lib: move upper_32_bits() and lower_32_bits() to library

Mrzyglod, Daniel T
2020-03-05T15:07:18Z

On Tue, 2020-03-03 at 13:14 +0200, Petri Latvala wrote:
> On Tue, Mar 03, 2020 at 11:34:12AM +0100, Daniel Mrzyglod wrote:
> > Move inline upper_32_bits() and lower_32_bits() function from tests
> > to
> > library. Functiom will be usefull for elsewhere use.
> >
> > Cc: Katarzyna Dec <katarzyna.dec@intel.com>
> > Signed-off-by: Daniel Mrzyglod <daniel.t.mrzyglod@intel.com>
> > ---
> > lib/ioctl_wrappers.h | 20 ++++++++++++++++++++
> > tests/i915/gem_exec_fence.c | 10 ----------
> > 2 files changed, 20 insertions(+), 10 deletions(-)
> >
> > diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
> > index 7614e688c..17f54b2f9 100644
> > --- a/lib/ioctl_wrappers.h
> > +++ b/lib/ioctl_wrappers.h
> > @@ -244,4 +244,24 @@ static inline void *from_user_pointer(uint64_t
> > u64)
> > return (void *)(uintptr_t)u64;
> > }
> >
> > +/**
> > + * lower_32_bits
> > + *
> > + * return bits 0-31 of a number
> > + */
> > +static inline uint32_t lower_32_bits(uint64_t x)
> > +{
> > + return x & 0xffffffff;
> > +}
> > +
> > +/**
> > + * lower_32_bits
> > + *
> > + * return bits 32-63 of a number
>
> upper_
>
> Does the name need a colon : after it to be recognized? Can you build
> docs and check that these appear?
>
>

I will fix docs error.
static inlines will not apper there are no references in docs for any
static inline in code

Daniel