From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/3] tests/gem_userptr_blits: More effectively set pages before invalidation
Date: Wed, 4 Mar 2020 10:58:39 +0100 [thread overview]
Message-ID: <20200304095841.8781-2-janusz.krzysztofik@linux.intel.com> (raw)
In-Reply-To: <20200304095841.8781-1-janusz.krzysztofik@linux.intel.com>
It has been observed that mmap-offset-invalidate@wb subtest has never
triggered a lockdep loop complain. To fix it, don't use the ->domain
field of a mapping type being examined, always set read and write
domains to I915_GEM_DOMAIN_GTT instead.
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
tests/i915/gem_userptr_blits.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
index cd1a3af27..8148d7d76 100644
--- a/tests/i915/gem_userptr_blits.c
+++ b/tests/i915/gem_userptr_blits.c
@@ -821,7 +821,7 @@ static void test_mmap_offset_invalidate(int fd, const struct mmap_offset *t)
igt_require_f(map, "mmap-offset banned, lockdep loop prevention\n");
/* set object pages in order to activate MMU notifier for it */
- gem_set_domain(fd, handle, t->domain, t->domain);
+ gem_set_domain(fd, handle, I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
/* trigger the notifier */
munmap(ptr, PAGE_SIZE);
--
2.21.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-04 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 9:58 [igt-dev] [PATCH i-g-t 0/3] tests/gem_userptr_blits: mmap-offset-invalidate enhancements Janusz Krzysztofik
2020-03-04 9:58 ` Janusz Krzysztofik [this message]
2020-03-04 9:58 ` [igt-dev] [PATCH i-g-t 2/3] tests/gem_userptr_blits: More exact detection of lockdep loop prevention Janusz Krzysztofik
2020-03-04 9:58 ` [igt-dev] [RFC PATCH i-g-t 3/3] tests/gem_userptr_blits: Add active variant of mmap-offset-invalidate Janusz Krzysztofik
2020-03-04 10:32 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/gem_userptr_blits: mmap-offset-invalidate enhancements Patchwork
2020-03-05 3:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-05 11:01 ` Janusz Krzysztofik
2020-03-05 11:19 ` [igt-dev] ✗ Fi.CI.IGT: failure for gem_userptr_blits: " Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304095841.8781-2-janusz.krzysztofik@linux.intel.com \
--to=janusz.krzysztofik@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox