Re: [igt-dev] [PATCH i-g-t v4] tests/kms_chamelium: Add support to validate RGB/YUV pixel formats

Kunal Joshi
2020-03-09T08:05:15Z

On 2020-03-06 at 15:06:12 +0200, Petri Latvala wrote:
> On Fri, Mar 06, 2020 at 05:32:55AM +0530, Kunal Joshi wrote:
> > Currently, only hard coded pixel formats are validated which are not
> > generic across platforms which leads to SKIPS.
> > Added support to validate only those pixel formats which are supported by
> > platform. Covering both RGB and YUV pixel formats.
> >
> > v2: added support for RGB pixel formats (Swati)
> > v3: simplified constraint and made it more readable (Petri)
> > v4: -used igt_format_str instead of macro to print fourcc code (Ville)
> > -dropped patch#1 because of above change
> >
> > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> > ---
> > tests/kms_chamelium.c | 124 +++++++++++++++++++-------------------------------
> > 1 file changed, 48 insertions(+), 76 deletions(-)
> >
> > diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> > index 5c4a189..a0ec925 100644
> > --- a/tests/kms_chamelium.c
> > +++ b/tests/kms_chamelium.c
> > @@ -2612,6 +2612,14 @@ static const struct edid *get_edid(enum test_edid edid)
> > if (chamelium_port_get_type(port) == \
> > DRM_MODE_CONNECTOR_ ## type__)
> >
> > +#define connector_subtest_start(name__, type__) \
> > + igt_subtest_with_dynamic(name__) \
> > + for_each_port(p, port) \
> > + if (chamelium_port_get_type(port) == \
> > + DRM_MODE_CONNECTOR_ ## type__) {
> > +
> > +#define connector_subtest_end }
>
> I'd prefer these macros without { and } and for the caller to write
> them. That helps editors supply the correct indentation. I guess that
> makes the _end macro useless, so just #define connector_subtest.
>
>

Agree with you petri.
Will correct it in the patch

> --
> Petri Latvala

Thanks
Kunal