Re: [igt-dev] [PATCH i-g-t 3/3] kms/test: Pass correct pipe value to print pipe name

Jani Nikula
2020-03-09T08:49:11Z

On Sun, 08 Mar 2020, Mohammed Khajapasha <mohammed.khajapasha@intel.com> wrote:
> currently kmstest_pipe_name() fn gets the pipe index
> value to print the pipe name, but with non-contiguous
> display, pipe index is not always same as pipe name.
>
> for example: if PIPE_A is disabled in kernel, PIPE_B,C & D
> get registered with 0,1 & 2 indexes in mode config's crtc list
> and kmstest_pipe_name() always prints PIPE_A for 0 index
> which is actually PIPE_B in kernel.

IMO if you have enum pipe pipe in IGT, it should match the kernel pipe.

If you have crtc indexes in igt, then you should call them crtc indexes,
*not* pipes.

Otherwise you'll end up completely lost when a pipe is a pipe and when
it's not.

> igt_info("Running test on pipe %s with resolution %dx%d and sprite size %dx%d alpha %i\n",
> - kmstest_pipe_name(pipe), mode->hdisplay, mode->vdisplay,
> + kmstest_pipe_name(display->pipes[pipe].pipe), mode->hdisplay, mode->vdisplay,

For example in changes like this my only conclusion is that the pipe is
not really a pipe, but something else. So you should probably not call
it a pipe to begin with.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center