Re: [igt-dev] [PATCH i-g-t 3/3] kms/test: Pass correct pipe value to print pipe name

Jani Nikula
2020-03-10T08:20:40Z

On Tue, 10 Mar 2020, "Khajapasha, Mohammed" <mohammed.khajapasha@intel.com> wrote:
> Are you saying, we should get rid of pipe enum and make it array index
> based? Is my understanding correct? At present, every IGT subtest
> iterates over pipe list using "enum pipe" and this is getting passed
> down.

I am saying do not conflate enum pipe and crtc index.

If you call something a pipe, it should be the pipe, not crtc index. And
vice versa.

It gets really confusing really quick if you call something a pipe, and
then go on to convert it into a pipe, as if it wasn't a pipe already.

In i915 we've removed all assumptions that pipe == crtc index. So should
igt.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center