From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BFAF89798 for ; Mon, 9 Mar 2020 11:01:08 +0000 (UTC) Date: Mon, 9 Mar 2020 13:01:05 +0200 From: Petri Latvala Message-ID: <20200309110105.GZ3839@platvala-desk.ger.corp.intel.com> References: <20200302173314.378918-1-emil.l.velikov@gmail.com> <20200303131315.GO3839@platvala-desk.ger.corp.intel.com> <20200304112511.GQ3839@platvala-desk.ger.corp.intel.com> <20200304141717.GR3839@platvala-desk.ger.corp.intel.com> <20200306142806.GY3839@platvala-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t v3] ts/core_setmaster: new test for drop/set master semantics List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Emil Velikov Cc: IGT development List-ID: On Fri, Mar 06, 2020 at 04:32:19PM +0000, Emil Velikov wrote: > On Fri, 6 Mar 2020 at 14:28, Petri Latvala wrote: > > > It is _extremely_ likely that we (i915 CI) could sometimes run > > igt@i915_module_load@reload right before this test. Or > > igt@i915_selftest@live. When we do, there's no /dev/dri/card0 at the > > time of chmodding but is at the time of __drm_open_driver(). > > > If I understand you correctly, if a test which does rmmod/modprobe > fails, the CI will still continue to run other tests. It's worse than that. All subtests of i915_module_load except @reload leave the module unloaded also on _success_. i915_selftest likewise leaves the module unloaded. If they loaded the module back on success, running module loading tests back-to-back would do an additional module reload roundtrip. -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev