Re: [igt-dev] [PATCH i-g-t] test/perf: Add test to verify OA TLB invalidation

Chris Wilson
2020-03-13T17:51:23Z

Quoting Umesh Nerlige Ramappa (2020-03-13 17:42:35)
> @@ -4622,6 +4708,12 @@ igt_main
> gen8_test_single_ctx_render_target_writes_a_counter();
> }
>
> + igt_describe("Test OA TLB invalidate");
> + igt_subtest("gen12-oa-tlb-invalidate") {
> + igt_require(intel_gen(devid) >= 12);
> + gen12_test_oa_tlb_invalidate();
> + }
> +
> igt_describe("Measure performance for a specific context using OAR in Gen 12");
> igt_subtest("gen12-unprivileged-single-ctx-counters") {
> igt_require(intel_gen(devid) >= 12);

Something you might like to add is:

igt_subtest_group {
igt_fixture igt_require(intel_gen(devid) >= 12);

igt_describe("Test OA TLB invalidate");
igt_subtest("gen12-oa-tlb-invalidate")
gen12_test_oa_tlb_invalidate();

igt_describe("Measure performance for a specific context using OAR in Gen 12");
igt_subtest("gen12-unprivileged-single-ctx-counters")
...
}

To combat the redundancy and add some visual grouping.
-Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.