From: Lyude <lyude@redhat.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default
Date: Mon, 16 Mar 2020 12:11:28 -0400 [thread overview]
Message-ID: <20200316161132.29833-1-lyude@redhat.com> (raw)
From: Lyude Paul <lyude@redhat.com>
It appears that since GCC 10, -fcommon has become the default over the
previous -fno-common causing igt builds to fail by default. Likewise,
we've also started setting -fcommon by default when building RPMs in
Fedora (likewise, this has broken igt-gpu-tools builds for a while and
I'm only just now getting to fixing it). So, let's fix the issues this
introduced and make -fcommon the default in igt as well to prevent
breakages from this in the future.
Lyude Paul (4):
lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern
lib/rendercopy_gen*: Make cc/viewport static
assembler/gen4asm.h: Make struct src_operand extern
meson: Add -fcommon to cc_flags
assembler/gen4asm.h | 2 +-
lib/igt_core.c | 3 +++
lib/igt_core.h | 4 ++--
lib/rendercopy_gen8.c | 4 ++--
lib/rendercopy_gen9.c | 4 ++--
meson.build | 1 +
6 files changed, 11 insertions(+), 7 deletions(-)
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-03-16 16:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 16:11 Lyude [this message]
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern Lyude
2020-03-16 23:11 ` Chris Wilson
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static Lyude
2020-03-16 23:11 ` Chris Wilson
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern Lyude
2020-03-16 23:08 ` Chris Wilson
2020-03-17 16:56 ` Lyude Paul
2020-03-19 17:29 ` Lyude Paul
2020-03-16 23:10 ` Chris Wilson
2020-03-19 17:40 ` [igt-dev] [PATCH i-g-t v2] assembler/gen4asm.h: Remove struct src_operand src_operand variable Lyude
2020-03-20 12:24 ` Petri Latvala
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 4/4] meson: Add -fcommon to cc_flags Lyude
2020-03-17 6:34 ` Petri Latvala
2020-03-16 17:16 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes for GCC 10's -fcommon default Patchwork
2020-03-17 0:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-19 18:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fixes for GCC 10's -fcommon default (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316161132.29833-1-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox