From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows
Date: Wed, 18 Mar 2020 22:16:31 +0200 [thread overview]
Message-ID: <20200318201631.14580-1-juhapekka.heikkila@gmail.com> (raw)
Change test initialization so CRC buffer will not become full
on slower machines.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_plane_multiple.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 255cd34a..78769933 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -121,8 +121,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
igt_skip_on(ret != 0);
- igt_pipe_crc_start(data->pipe_crc);
- igt_pipe_crc_get_single(data->pipe_crc, &data->ref_crc);
+ igt_pipe_crc_collect_crc(data->pipe_crc, &data->ref_crc);
}
static void
@@ -257,6 +256,7 @@ prepare_planes(data_t *data, enum pipe pipe_id, color_t *color,
igt_plane_set_position(data->plane[i], x[i], y[i]);
igt_plane_set_fb(data->plane[i], &data->fb[i]);
+ igt_pipe_crc_drain(data->pipe_crc);
}
/* primary plane */
@@ -330,6 +330,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
igt_output_name(output), kmstest_pipe_name(pipe), c,
info, opt.seed);
+ igt_pipe_crc_start(data->pipe_crc);
+
i = 0;
while (i < iterations || loop_forever) {
/* randomize planes and set up the holes */
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-03-18 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:16 Juha-Pekka Heikkila [this message]
2020-03-18 21:03 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Avoid CRC buffer overflows Patchwork
2020-03-18 23:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-03-19 14:06 [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
2020-03-20 13:03 ` Kahola, Mika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318201631.14580-1-juhapekka.heikkila@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox