From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 428486E09C for ; Wed, 25 Mar 2020 13:14:54 +0000 (UTC) Date: Wed, 25 Mar 2020 15:14:51 +0200 From: Petri Latvala Message-ID: <20200325131451.GA9497@platvala-desk.ger.corp.intel.com> References: <20200325123318.240545-1-chris@chris-wilson.co.uk> <20200325125823.240720-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200325125823.240720-1-chris@chris-wilson.co.uk> Subject: Re: [igt-dev] [PATCH i-g-t v2] runner: Only show the kmsg overflow message once List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org List-ID: On Wed, Mar 25, 2020 at 12:58:23PM +0000, Chris Wilson wrote: > Instead of repeating every single time we overflow the read from kmsg, > just once per test is enough warning. > > v2: Just suppress the multiple s/underflow/overflow/ messages. Having a > buffer smaller than a single kmsg packet is unlikely. > > Signed-off-by: Chris Wilson > Cc: Petri Latvala Reviewed-by: Petri Latvala > --- > runner/executor.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/runner/executor.c b/runner/executor.c > index a56cb5d66..d72a59376 100644 > --- a/runner/executor.c > +++ b/runner/executor.c > @@ -549,6 +549,7 @@ static int dump_dmesg(int kmsgfd, int outfd) > int comparefd; > unsigned flags; > unsigned long long seq, cmpseq, usec; > + bool underflow_once = false; > char cont; > char buf[2048]; > ssize_t r; > @@ -586,7 +587,10 @@ static int dump_dmesg(int kmsgfd, int outfd) > r = read(kmsgfd, buf, sizeof(buf)); > if (r < 0) { > if (errno == EPIPE) { > - errf("Warning: kernel log ringbuffer underflow, some records lost.\n"); > + if (!underflow_once) { > + errf("Warning: kernel log ringbuffer underflow, some records lost.\n"); > + underflow_once = true; > + } > continue; > } else if (errno == EINVAL) { > errf("Warning: Buffer too small for kernel log record, record lost.\n"); > -- > 2.26.0 > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev